Update RDF and replace AFV-EuroScope Bridge plugins

luke11brown commented 7 months ago

What is the current situation?

AFV bridge and RDF plugins are versions included:

What is the proposed change?

Replace both of these plugins with the single solution provided:

https://github.com/KingfuChan/RDF

Additional context

This provides the following benefits:

Single plugin provides the functionality of the previous two
AFV bridge compatible with other voice software such as VectorAudio & TrackAudio
RDF settings can be defined on a per ASR basis
More RDF filtering/customisations available

kristiankunc commented 7 months ago

I'd like to do this. Is it just a matter of replacing the plugin DLLs or some additional configuration should be done?

luke11brown commented 7 months ago

Certainly replacing the DLLs is a start.

I think we'll be looking to also do the following:

Set precision values
Set altitude filters for both precision and total functionality.

This can be achieved via the settings described https://github.com/KingfuChan/RDF/blob/master/README.md

For now, please set the same values for all ASRs and we can discuss what is suitable @hazzas-99 @PLM1995

kristiankunc commented 7 months ago

I've tried playing around with the plugin and it ended up crashing my ES quite a lot. I've created an issue on the RDF repo to track it. https://github.com/KingfuChan/RDF/issues/5

PLM1995 commented 7 months ago

I've tried playing around with the plugin and it ended up crashing my ES quite a lot. I've created an issue on the RDF repo to track it. KingfuChan/RDF#5

I'm assuming you've already followed the steps to mitigate against the known issues which cause ES crashes, but since your report is rather minimalist, might be worth clarifying what other plugins were you using at the time, and how you had them configured.

kristiankunc commented 7 months ago

I'm assuming you've already followed the steps to mitigate against the known issues which cause ES crashes, but since your report is rather minimalist, might be worth clarifying what other plugins were you using at the time, and how you had them configured.

Yeah I have, not sure what caused it possibly some odd config but seems to work alright now

luke11brown commented 6 months ago

Ok,

so we'll need to set up all Plugins.txt with the settings below

PLUGINS

<eventually existing configuration lines>
RDF Plugin for Euroscope:VectorAudioAddress:127.0.0.1:49080
RDF Plugin for Euroscope:VectorAudioTimeout:300
RDF Plugin for Euroscope:VectorAudioPollInterval:200
RDF Plugin for Euroscope:VectorAudioRetryInterval:5
RDF Plugin for Euroscope:RGB:255:255:255
RDF Plugin for Euroscope:ConcurrentTransmissionRGB:255:0:0
RDF Plugin for Euroscope:Radius:20
RDF Plugin for Euroscope:Threshold:-1
RDF Plugin for Euroscope:Precision:0
RDF Plugin for Euroscope:LowAltitude:0
RDF Plugin for Euroscope:HighAltitude:0
RDF Plugin for Euroscope:LowPrecision:0
RDF Plugin for Euroscope:HighPrecision:0
RDF Plugin for Euroscope:DrawControllers:0
END

And we'll need to set up all ASRs with the ASR specific settings

I'm not one that actually uses this plugin, as it's unrealistic (in the UK) However, my understanding is it uses triangulation from transceivers, therefore it is only accurate at high levels, I suggest we effectively disable it at low levels, as ground controllers should not need to use this. If they are using it, in my opinion it shows poor management of their frequency. Of course, I'm happy to be corrected if someone else knows different on how it works/where it is used IRL.

ASR settings below

PLUGIN:RDF Plugin for Euroscope:RGB:255:255:255
PLUGIN:RDF Plugin for Euroscope:ConcurrentTransmissionRGB:255:255:0
PLUGIN:RDF Plugin for Euroscope:Radius:20
PLUGIN:RDF Plugin for Euroscope:Threshold:-1
PLUGIN:RDF Plugin for Euroscope:Precision:0
PLUGIN:RDF Plugin for Euroscope:LowAltitude:0
PLUGIN:RDF Plugin for Euroscope:HighAltitude:0
PLUGIN:RDF Plugin for Euroscope:LowPrecision:0
PLUGIN:RDF Plugin for Euroscope:HighPrecision:0
PLUGIN:RDF Plugin for Euroscope:DrawControllers:1

kristiankunc commented 6 months ago

I suggest we effectively disable it at low levels, as ground controllers should not need to use this.

I see what you mean. I am not sure how many people actually use it on ground, but I do personally, even though it's unrealistic. So I wouldn't be for "disabling" it on ground, rather make it work as well for those that want it.

PLM1995 commented 6 months ago

I fully agree with Luke, unless it's an IRL thing, there is absolutely no need for a GND/TWR controller to use RDF.

In general we go for the pack being realistic, then if people want to tweak things to make it unrealistic they can do that themselves @kristiankunc, I wouldn't be in favour of this being on by default for GND/TWR (unless as Luke says it's a RW thing).

luke11brown commented 6 months ago

Further thoughts,

If we adjust the precision to a realistic value for low altitudes then this will also make the use in ADC situations almost pointless, as it will likely not be precise enough over the space of an airfield, as it will show in the wrong place.

kristiankunc commented 6 months ago

If we adjust the precision to a realistic value for low altitudes then this will also make the use in ADC situations almost pointless

I wouldn't be in favour of this being on by default for GND/TWR (unless as Luke says it's a RW thing).

I am certainly for disabling it by default, but I believe if someone wants to use it as GND/TWR, they should be able to enable it with usable settings. Even though it is unrealistic.

kristiankunc commented 5 months ago

Okay I'd like to get back to this, do you think that leaving the functionality for ADC while disabling it by default is not desirable?

luke11brown commented 5 months ago

The main reason for this PR was to consolidate the RDF and AFV bridge plugins to a single plugin that is being actively developed, whilst adding the websocket access for TrackAudio.

Unfortunately, it appears that we can't have the AFV bridge functions added with this plugin, without adding unrealistic functions of RDF. IMO, the pack should aim to simulate the various ATM systems used by controllers in the UK. RDF isn't one of those things. That's why we include it at the moment, but don't load the plugin by default, as we understand some controllers like the RDF functionality.

I therefore think that instead, we should look to ask Andy to include the TrackAudio integration in the AFV bridge plugin. I will raise an issue there and leave this issue open for now.

VATSIM-UK / uk-controller-pack