search

VBIndex / py_vb_toolbox

Vogt-Bailey index toolbox in Python
GNU General Public License v3.0
12 stars 12 forks source link

Fix path names #19

Closed LucasCampos closed 4 years ago

LucasCampos commented 4 years ago

These are actually two closely related issues.

  1. We currently use "absolute" paths (i.e., vb_toolbox.numerics). These should be changed to relative paths (numerics).
  2. The io module we introduce conflicts with the standard library io module.

These changes are easy to do, and should be done ASAP. They are not done yet because I would prefer to wait after the Hackathon projects (PR #16 and #18) are merged.

KeithGeorgeCiantar commented 4 years ago

I am not sure if it is necessary to change from absolute imports to relative imports. The PEP 8 standard tends to recommend absolute paths because they are more readable and less problematic.

LucasCampos commented 4 years ago

I personally don't fully agree with the argument made by PEP8, but might be my C++ bias speaking. Altogether, I think we are better off following PEP8 than not. So, in light of your argument, I will make this issue as closed.

claudebajada commented 4 years ago

@LucasCampos - what about the conflict on the naming of the io module?

LucasCampos commented 4 years ago

That is not an issue at all if one is using absolute path names.

On Tue, 21 Jul 2020 at 10:33, claudebajada notifications@github.com wrote:

@LucasCampos https://github.com/LucasCampos - what about the conflict on the naming of the io module?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/VBIndex/py_vb_toolbox/issues/19#issuecomment-661716630, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAU3Z7RPQWWHE65QYI53OIDR4VHENANCNFSM4ODRELYQ .