VBIndex / py_vb_toolbox

Vogt-Bailey index toolbox in Python
GNU General Public License v3.0
12 stars 12 forks source link

Implementation of hybrid VB #31

Closed paola-g closed 3 years ago

paola-g commented 3 years ago

The hybrid approach is a modification of the searchlight analysis where the neighborhood of a given vertex is computed in volumetric space.

Two separate functions were added implementing the new functionality: vb_hybrid and vb_hybrid_internal_loop (plus the helper function get_neighborhood).

The app.py file was edited to handle new parameters:

The input data are still passed with the --data flag, but they should be in a NIfTI file (rather than a GIfTI).

Backward compatibility should be preserved.

LucasCampos commented 3 years ago

Hey! Thanks for the pull request!

I took a look at the code, and it all seems fine to me! I cannot test it right now, though. Could you check, @claudebajada? Once you are okay with it, I am fine with merging the code.

BTW, I particularly like the addition of traceback, and we might want to add it to the other modules.

claudebajada commented 3 years ago

I will review some time next week!

claudebajada commented 3 years ago

@all-contributors please add @paola-g for code

allcontributors[bot] commented 3 years ago

@claudebajada

I've put up a pull request to add @paola-g! :tada: