search

VBIndex / py_vb_toolbox

Vogt-Bailey index toolbox in Python
GNU General Public License v3.0
12 stars 12 forks source link

Minor issues #39

Closed ChristineFarrugia closed 1 year ago

ChristineFarrugia commented 1 year ago

1) [Line 406 of vb_index.py (reproduced below)]: To check whether this line is necessary (the function create_affinity_matrix of numerics.py was modified to account for 1D neighborhoods) neighborhood = np.squeeze(neighborhood[to_keep,:]) 2) [get_neighborhood function, in vb_index.py]: To consider replacing np.round(x) with int(x+0.5) (since np.round rounds 'half float numbers' to the nearest even number... so for example, np.round(5.5) = 6, but np.round(4.5) = 4) 3) [UserWarning in numerics.py]: Raises AttributeError: module 'warnings' has no attribute 'UserWarning'.

paola-g commented 1 year ago

We decided not to change anything regarding issue 1&2. The UserWarning error is now solved in the dev branch.