search

VC-MIPI-modules / vc_mipi_nvidia

Vision Components MIPI CSI-2 driver for NVIDIA Jetson Nano, Xavier NX, AGX Xavier, TX2 and Orin Nano, Orin NX
69 stars 31 forks source link

Update setup_helper.sh #68

Closed xaprier closed 4 months ago

xaprier commented 4 months ago

Fixes checksum error in issue: https://github.com/VC-MIPI-modules/vc_mipi_nvidia/issues/64

bazo80 commented 4 months ago

Hello @xaprier

thank you for your proposal/contribution. I've already made a fix for that problem (bazo_integ_0170, which will be merged into the release 0.17) But the problem is a little bit more complex, because the quickstart.sh script is setting the option -e (exit immediately on error). Since both scripts, the setup.sh and also the setup_helper.sh are being sourced

(. setup.sh --host)

and

. helper/setup_helper.sh

this option is still present, because it is the same shell. That means, if there is a file present, but the checksum is wrong, then this md5sum call would return 1 and the script would be exiting again. So now this call is made in a subshell, returning the value, which can be evaluated, but it won't cause the caller to quit:

DL_RESULT=$(echo "$CHECKSUM_VAR $FILE_VAR" | md5sum -c >/dev/null ; echo $? )

But thank you anyway, it is always appreciated when people care :)

xaprier commented 4 months ago

Appreciated that. Also we got 2 IMX568 frames in Orin Nano in the same time by editing device tree, but there are some complex problems we cannot understand it. I will create another branch for that in the next time.