search

VCCE / VCC

Tandy Color Computer 3 Emulator
GNU General Public License v3.0
64 stars 22 forks source link

Projects & code have unnecessary dependency on MFC #56

Closed Chet-Simpson-ATI closed 1 year ago

Chet-Simpson-ATI commented 3 years ago

Even though the projects do not utilize MFC all resource files are referencing afxres.h for their Windows resource specific symbolics and afxwin.h for functionality. These header files and the associated libraries are part of MFC which is not included in newer versions of Visual Studio and thus may not be installed. Since there is no real dependency on MFC libraries (except for AfxInitRichEdit which should be changeD) use of those header files should be changed.

This should be changed to use winres.h and windows.h respectively to remove the dependency and allow easier building with newer versions of VS and other platforms (cross compile from GCC).

BGPierce commented 3 years ago

Will this change break WindowsXP compatibility?

-----Original Message----- From: Chet-Simpson-ATI notifications@github.com To: VCCE/VCC VCC@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Sent: Mon, Dec 7, 2020 1:17 pm Subject: [VCCE/VCC] Projects & code have unnecessary dependency on MFC (#56)

Even though the projects do not utilize MFC all resource files are referencing afxres.h for their Windows resource specific symbolics and afxwin.h for functionality. These header files and the associated libraries are part of MFC which is not included in newer versions of Visual Studio and thus may not be installed. Since there is no real dependency on MFC libraries (except for AfxInitRichEdit which should be changeD) use of those header files should be changed.This should be changed to use winres.h and windows.h respectively to remove the dependency and allow easier building with newer versions of VS and other platforms (cross compile from GCC).— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

ejaquay commented 3 years ago

AfxInitRichEdit is used in the tape dialog to set font in text boxes. It looks like this could be changed. Doubt it would have any effect on WindowsXP. Sounds like a someday project.