Normal Warps' level inputs to 5v and make pots attenuate to match hardware and manual

VCVRack / AudibleInstruments

VCV Rack plugin based on Mutable Instruments Eurorack modules

https://vcvrack.com/AudibleInstruments.html

Other

383 stars 84 forks source link

Normal Warps' level inputs to 5v and make pots attenuate to match hardware and manual #106

Closed qiemem closed 3 years ago

qiemem commented 3 years ago

This matches the behavior of my hardware Warps as well as the description of level inputs in the manual.

Note that the level 1 pot still operate additively with level 1 cv for controlling the frequency of the internal oscillator as that is handled separately on line 84.

SteveRussell33 commented 3 years ago

PR for knob colours already made here: https://github.com/VCVRack/AudibleInstruments/pull/87/commits/c41343ddfc99cf1c811f064442d2b416a8f2328a

qiemem commented 3 years ago

Ack, GH automatically updated the PR. I didn't mean to include that commit. I was going to submit a separate PR for colors, but then saw your PR and didn't. I'll remove that commit when I get a chance. Thanks for the heads up.