search

VCVRack / AudibleInstruments

VCV Rack plugin based on Mutable Instruments Eurorack modules
https://vcvrack.com/AudibleInstruments.html
Other
383 stars 84 forks source link

Veils is no longer unipolar #111

Closed mhetrick closed 2 years ago

mhetrick commented 2 years ago

On the v1 Rack build, the Veils clone has correct, unipolar gain knobs like the Veils hardware. On the v2 Rack build, the knobs are now bipolar. This seems like an inappropriate change since Veils is intended to be a VCA mixer while Blinds is the polarizing mixer.

mhetrick commented 2 years ago

Here is the offending commit: https://github.com/VCVRack/AudibleInstruments/commit/bb1167e3974ad00ad2f8bf4c32ebe26589b312b6

It looks like the Veils labels were copied from Blinds and not corrected to be unipolar after.

AndrewBelt commented 2 years ago

Nice catch! Fixed in 7225bf8