Closed cschol closed 6 years ago
Don't like the static globals. It's a moderately easy fix to make those class variables.
I moved the static globals into the class. The IOBuffer
members are now part of the Peaks
class, which eliminated the need for the static process
function outside of class scope.
Okay, looks a lot better. Won't have time to test this for the next few weeks.
That's cool. Can we disable the Peaks
model in this PR and get it merged so folks can build it from source if they want? This would allow getting some stick time on it. I went through all modes and tested and everything it working again as expected.
@cschol Is there some way I can pull the new codebase for Peaks to test it ?
@davephillips You can try this repo. Just re-enable the model in AudibleInstruments.cpp
.
@cschol Wow, thanks a lot, Chris, it works ! I just did some quick tests of the drums and the number station but so far it's working like the examples I've found on YouTube for the original hardware. I'll give it a more extensive run-through tomorrow to test all the functions & modes. Nice work ! :)
@cschol I followed DivKid's MI Peaks video at https://www.youtube.com/watch?v=qR82LP9MuM0&t=319s, got most of it under my hat now, though I haven't got the hang of the Env mode the way the video works it. Otherwise, things are sounding sweet, it's an impressive module.
@cschol A little follow-up. I got the hang of the Env mode, took a bit of fussing with DivKid's example but I did get it working pretty much like he demonstrates.
@AndrewBelt Did the Peaks fix get merged in or why was this closed?
I don't remember closing this so maybe I fat fingered it?
Ah, it's because I renamed the branch to v0.6
.
I see. Do you want me to resubmit the PR with the new branch?
Sure, I think that's the only way. It's not letting me reopen it.
process()
function to accessstd::
fromabs
to allow compilation on older compilersFixes #49.