search

VCVRack / AudibleInstruments

VCV Rack plugin based on Mutable Instruments Eurorack modules
https://vcvrack.com/AudibleInstruments.html
Other
383 stars 84 forks source link

Texture Synthesizer Trigger input acts as Gate #93

Open cschol opened 4 years ago

cschol commented 4 years ago

(Hardware) Clouds has a Trigger input to initiate grain seeding. This is an actual trigger, not a gate. I noticed a difference in behavior when using my hardware Clouds in comparison to the Rack version.

The Texture Synthesizer implements this Trigger input as a gate, i.e. as long as Trigger input is > 1V the grains are seeded.

Note, that the gate member of the parameter class is not used in the Clouds code. It is set in the Texture Synthesizer implementation in Rack, but has no effect. The issue here is that the trigger member of the parameter class is implemented as a gate in Clouds.cpp.

Do you want a PR to fix this? (two line change)

eggix commented 3 years ago

I would love to see it fixed. Just create a PR. Also small changes are worth a PR. For example #102 was recently merged.