Error compiling against Rack v0.5

briansorahan commented 6 years ago

Seeing this with Rack v0.5, Befaco master:

➜  Befaco git:(master) make
g++ -I./pffft -DPFFFT_SIMD_DISABLE -fPIC -I../../include -I../../dep/include -DVERSION=0.5.0 -MMD -g -O3 -march=nocona -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_LIN -Wsuggest-override -std=c++11 -c -o build/src/SpringReverb.cpp.o src/SpringReverb.cpp
src/SpringReverb.cpp: In member function ‘virtual void SpringReverb::step()’:
src/SpringReverb.cpp:219:13: error: ‘struct rack::SampleRateConverter<1>’ has no member named ‘setRates’; did you mean ‘setRatio’?
    inputSrc.setRates(engineGetSampleRate(), 48000);
             ^~~~~~~~
             setRatio
src/SpringReverb.cpp:231:14: error: ‘struct rack::SampleRateConverter<1>’ has no member named ‘setRates’; did you mean ‘setRatio’?
    outputSrc.setRates(48000, engineGetSampleRate());
              ^~~~~~~~
              setRatio
make: *** [../../compile.mk:54: build/src/SpringReverb.cpp.o] Error 1

I am on arch linux:

➜  Befaco git:(master) uname -a
Linux sorahan-desktop 4.14.4-1-ARCH #1 SMP PREEMPT Tue Dec 26 19:10:06 UTC 2017 x86_64 GNU/Linux

AndrewBelt commented 6 years ago

git checkout v0.5.0 in the Befaco repository.

AndrewBelt commented 6 years ago

You were good after checking out the v0.5.0. No need to pull. And the correct way to do that is git pull origin master

biomassa commented 6 years ago

thank you! i figured it out. please excuse my lack of skills. it's all very new to me.

briansorahan commented 6 years ago

@AndrewBelt Compiling against Befaco v0.5.0 worked. Thanks!

VCVRack / Befaco

Error compiling against Rack v0.5 #5