Fix VCA-1 out of bounds fill

VCVRack / Fundamental

https://vcvrack.com/Fundamental

Other

236 stars 76 forks source link

Fix VCA-1 out of bounds fill #129

Closed falkTX closed 2 years ago

falkTX commented 3 years ago

Under some conditions these calls will paint out of bounds, due to there not being a valid path. I looked around in other modules, and with those I checked, no single other module does this.

falkTX commented 3 years ago

To make things easier, please take these changes and do with them as you please. README says "Since Fundamental will be packaged with VCV Rack for DAWs, we cannot accept pull requests" so I am here in written text giving you full rights to the patch / code changes.

AndrewBelt commented 2 years ago

We are unfortunately unable to review or accept pull requests to VCV Fundamental due to copyright reasons regarding unlicensed third-party code in VCV Rack Pro. For more information see https://github.com/VCVRack/Rack/blob/v2/.github/CONTRIBUTING.md. We encourage you to instead contact VCV Support for feature requests and bug fixes.