VCVRack / VCV-Prototype

Other
130 stars 23 forks source link

make dep fails in python build on macOS #17

Open JerrySievert opened 4 years ago

JerrySievert commented 4 years ago

looks like the python dep is failing on macOS (10.14, Xcode 11):

gcc -mmacosx-version-min=10.7 -stdlib=libc++ -mmacosx-version-min=10.7 -stdlib=libc++   -Wl,-stack_size,1000000  -framework CoreFoundation -o python.exe Programs/python.o -L. -lpython3.8 -ldl   -framework CoreFoundation
DYLD_LIBRARY_PATH=/Users/jerry/work/Rack/plugins/VCV-Prototype/dep/Python-3.8.0rc1 ./python.exe -E -S -m sysconfig --generate-posix-vars ;\
    if test $? -ne 0 ; then \
        echo "generate-posix-vars failed" ; \
        rm -f ./pybuilddir.txt ; \
        exit 1 ; \
    fi
/bin/sh: line 1: 57984 Killed: 9               DYLD_LIBRARY_PATH=/Users/jerry/work/Rack/plugins/VCV-Prototype/dep/Python-3.8.0rc1 ./python.exe -E -S -m sysconfig --generate-posix-vars
generate-posix-vars failed
make[1]: *** [pybuilddir.txt] Error 1
make: *** [dep/lib/libpython3.8.so.1.0] Error 2

I've never embedded python, so not sure where to go with this.

AndrewBelt commented 4 years ago

I haven't tested the Python build on Linux, so it might fail on Mac. Try disabling by setting PYTHON := 0 in the Makefile and commenting out the createPythonEngine in ScriptEngine.cpp?

JerrySievert commented 4 years ago

I built with make PYTHON=0 and had disabled it in ScriptEngine.cpp to move forward last night, it might be good to have it (or others) be conditional in ScriptEngine.cpp with a #if if and enable when PYTHON is defined.

mossheim commented 3 years ago

if i follow the python build steps verbatim on my own, it succeeds. i'm not too familiar with make, is it possible that environment vars set in the makefile (CFLAGS, LDFLAGS, etc.) are affecting the compilation?