search

VCVRack / VCV-Prototype

Other
130 stars 22 forks source link

Polish up supercollider engine #45

Closed mossheim closed 3 years ago

mossheim commented 3 years ago

@AndrewBelt finally got around to fixing up the build system. i tried to follow your comment suggestions, let me know how it looks. sorry for the delay!

mossheim commented 3 years ago

@AndrewBelt would you prefer i commit this directly to the v1 branch instead as other contributors have done? i am a bit hesitant to do that but will if you say so. :)

mossheim commented 3 years ago

@AndrewBelt just pushed this to v1 because it seems to be your intended workflow, so i'll close this now.

AndrewBelt commented 3 years ago

Sorry, I don't have time to review this. However, since this would be adding a new engine, can it stay disabled (SUPERCOLLIDER ?= 0) until I have time to review it?

mossheim commented 3 years ago

Do you have a clear timeline in mind? If not, I don't want to continue waiting. I have tested this myself on macOS and Arch Linux and encountered no issues. I am watching this repo and will happily respond to any issues related to the SC engine.