compile fails =: quickjs/quickjs.h: No such file or directory

[mxa]

Linux:

src/QuickJSEngine.cpp:2:10: fatal error: quickjs/quickjs.h: No such file or directory
    2 | #include <quickjs/quickjs.h>
      |          ^~~~~~~~~~~~~~~~~~~
compilation terminated.

[JerrySievert]

https://github.com/VCVRack/VCV-Prototype/blob/v1/README.md#make

[mxa]

I did that.

[JerrySievert]

can you show the results of ls -l in the root of VCV-Prototype?

[mxa]

drwxrwxr-x  3 max max      4096 Jan 20 21:46 build
-rw-rw-r--  1 max max      1268 Jan 20 21:25 CHANGELOG.md
drwxrwxr-x 12 max max      4096 Jun 21 01:14 dep
drwxrwxr-x  9 max max      4096 Jan 20 21:28 efsw
drwxrwxr-x  2 max max      4096 Jun  8 18:14 examples
drwxrwxr-x  7 max max      4096 Jun 21 01:24 faust_libraries
-rw-rw-r--  1 max max      3052 Jan 20 21:25 Faust.md
-rw-rw-r--  1 max max      1096 Jan 20 21:25 LICENSE-dist.txt
-rw-rw-r--  1 max max     35149 Jan 20 21:25 LICENSE-GPLv3.txt
-rw-rw-r--  1 max max       958 Jan 20 21:25 LICENSE.md
-rw-rw-r--  1 max max    849845 Mai  1  2017 LuaJIT-2.0.5.tar.gz
-rw-rw-r--  1 max max      9785 Jun 21 01:08 Makefile
-rw-rw-r--  1 max max       722 Jan 20 21:25 plugin.json
-rwxrwxr-x  1 max max 109849624 Jan 20 21:46 plugin.so
-rw-rw-r--  1 max max      4827 Jun  8 18:14 README.md
drwxrwxr-x  2 max max      4096 Jan 20 21:25 res
drwxrwxr-x  2 max max      4096 Jan 20 21:25 src
drwxrwxr-x  3 max max      4096 Jun  8 18:14 support
drwxrwxr-x  2 max max      4096 Jan 20 21:25 tests

[JerrySievert]

and can you post an ls -l of dep?

maybe the output of make dep as well.

[mxa]

drwxrwxr-x  2 max max 4096 Jun 21 01:24 bin
drwxrwxr-x 18 max max 4096 Jun 21 01:16 faust
drwxrwxr-x  6 max max 4096 Jun 21 01:24 include
drwxr-xr-x  4 max max 4096 Jun 21 01:24 lib
drwxrwxr-x 14 max max 4096 Jun 21 01:14 libpd
drwxr-xr-x  6 max max 4096 Mai  1  2017 LuaJIT-2.0.5
drwxrwxr-x  7 max max 4096 Jun 21 01:14 QuickJS
drwxrwxr-x  6 max max 4096 Jun 21 01:24 share
drwxrwxr-x 24 max max 4096 Jun 21 01:15 supercollider
drwxrwxr-x  2 max max 4096 Jun 21 01:14 vult

[JerrySievert]

and the make dep output?

[mxa]

Takes quite some time on my machine. (first deleting the dep folder is necessary) make_dep.txt

[mxa]

huh, running make again I get a different output this time.

make -j8
g++ -std=c++11 -Wsuggest-override  -Idep/include -Idep/supercollider/include -Idep/supercollider/include/common -Idep/supercollider/lang -Idep/supercollider/common -Idep/supercollider/include/plugin_interface -Idep/vult -Idep/include/libpd -DHAVE_LIBDL -DINTERP -fPIC -I/home/max/Code/Rack-SDK//include -I/home/max/Code/Rack-SDK//dep/include -MMD -MP -g -O3 -march=nocona -funsafe-math-optimizations -Wall -Wextra -Wno-unused-parameter -DARCH_LIN  -c -o build/src/Prototype.cpp.o src/Prototype.cpp
g++ -std=c++11 -Wsuggest-override  -Idep/include -Idep/supercollider/include -Idep/supercollider/include/common -Idep/supercollider/lang -Idep/supercollider/common -Idep/supercollider/include/plugin_interface -Idep/vult -Idep/include/libpd -DHAVE_LIBDL -DINTERP -fPIC -I/home/max/Code/Rack-SDK//include -I/home/max/Code/Rack-SDK//dep/include -MMD -MP -g -O3 -march=nocona -funsafe-math-optimizations -Wall -Wextra -Wno-unused-parameter -DARCH_LIN  -c -o build/src/QuickJSEngine.cpp.o src/QuickJSEngine.cpp
g++ -std=c++11 -Wsuggest-override  -Idep/include -Idep/supercollider/include -Idep/supercollider/include/common -Idep/supercollider/lang -Idep/supercollider/common -Idep/supercollider/include/plugin_interface -Idep/vult -Idep/include/libpd -DHAVE_LIBDL -DINTERP -fPIC -I/home/max/Code/Rack-SDK//include -I/home/max/Code/Rack-SDK//dep/include -MMD -MP -g -O3 -march=nocona -funsafe-math-optimizations -Wall -Wextra -Wno-unused-parameter -DARCH_LIN  -c -o build/src/LuaJITEngine.cpp.o src/LuaJITEngine.cpp
g++ -std=c++11 -Wsuggest-override  -Idep/include -Idep/supercollider/include -Idep/supercollider/include/common -Idep/supercollider/lang -Idep/supercollider/common -Idep/supercollider/include/plugin_interface -Idep/vult -Idep/include/libpd -DHAVE_LIBDL -DINTERP -fPIC -I/home/max/Code/Rack-SDK//include -I/home/max/Code/Rack-SDK//dep/include -MMD -MP -g -O3 -march=nocona -funsafe-math-optimizations -Wall -Wextra -Wno-unused-parameter -DARCH_LIN  -c -o build/src/SuperColliderEngine.cpp.o src/SuperColliderEngine.cpp
g++ -std=c++11 -Wsuggest-override  -Idep/include -Idep/supercollider/include -Idep/supercollider/include/common -Idep/supercollider/lang -Idep/supercollider/common -Idep/supercollider/include/plugin_interface -Idep/vult -Idep/include/libpd -DHAVE_LIBDL -DINTERP -fPIC -I/home/max/Code/Rack-SDK//include -I/home/max/Code/Rack-SDK//dep/include -MMD -MP -g -O3 -march=nocona -funsafe-math-optimizations -Wall -Wextra -Wno-unused-parameter -DARCH_LIN  -c -o build/src/VultEngine.cpp.o src/VultEngine.cpp
g++ -std=c++11 -Wsuggest-override  -Idep/include -Idep/supercollider/include -Idep/supercollider/include/common -Idep/supercollider/lang -Idep/supercollider/common -Idep/supercollider/include/plugin_interface -Idep/vult -Idep/include/libpd -DHAVE_LIBDL -DINTERP -fPIC -I/home/max/Code/Rack-SDK//include -I/home/max/Code/Rack-SDK//dep/include -MMD -MP -g -O3 -march=nocona -funsafe-math-optimizations -Wall -Wextra -Wno-unused-parameter -DARCH_LIN  -c -o build/src/LibPDEngine.cpp.o src/LibPDEngine.cpp
cd dep && git clone "https://github.com/supercollider/supercollider" --branch topic/vcv-prototype-support --depth 1
make: *** No rule to make target 'dep/supercollider/build/external_libraries/libtlsf.a', needed by 'plugin.so'.  Stop.
make: *** Waiting for unfinished jobs....
g++ -std=c++11 -Wsuggest-override  -Idep/include -Idep/supercollider/include -Idep/supercollider/include/common -Idep/supercollider/lang -Idep/supercollider/common -Idep/supercollider/include/plugin_interface -Idep/vult -Idep/include/libpd -DHAVE_LIBDL -DINTERP -fPIC -I/home/max/Code/Rack-SDK//include -I/home/max/Code/Rack-SDK//dep/include -MMD -MP -g -O3 -march=nocona -funsafe-math-optimizations -Wall -Wextra -Wno-unused-parameter -DARCH_LIN  -c -o build/src/FaustEngine.cpp.o src/FaustEngine.cpp
fatal: destination path 'supercollider' already exists and is not an empty directory.
make: *** [Makefile:114: dep/supercollider/build/lang/libsclang.a] Error 128
In file included from src/FaustEngine.cpp:44:
dep/include/faust/dsp/interpreter-dsp.h:29: warning: "DEPRECATED" redefined
   29 | #define DEPRECATED(fun) fun __attribute__ ((deprecated));
      | 
In file included from /home/max/Code/Rack-SDK//include/rack.hpp:6,
                 from src/ScriptEngine.hpp:2,
                 from src/FaustEngine.cpp:24:
/home/max/Code/Rack-SDK//include/common.hpp:28: note: this is the location of the previous definition
   28 |  #define DEPRECATED __attribute__ ((deprecated))
      | 
In file included from src/SuperColliderEngine.cpp:4:
dep/supercollider/lang/LangSource/SC_LanguageConfig.hpp:28:10: fatal error: boost/filesystem/path.hpp: No such file or directory
   28 | #include <boost/filesystem/path.hpp>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [/home/max/Code/Rack-SDK//compile.mk:69: build/src/SuperColliderEngine.cpp.o] Error 1
In file included from src/VultEngine.cpp:3:
dep/include/quickjs/quickjs.h: In function ‘JSValue JS_NewCFunctionMagic(JSContext*, JSValue (*)(JSContext*, JSValue, int, JSValue*, int), const char*, int, JSCFunctionEnum, int)’:
dep/include/quickjs/quickjs.h:826:34: warning: cast between incompatible function types from ‘JSValue (*)(JSContext*, JSValue, int, JSValue*, int)’ to ‘JSValue (*)(JSContext*, JSValue, int, JSValue*)’ [-Wcast-function-type]
  826 |     return JS_NewCFunction2(ctx, (JSCFunction *)func, name, length, cproto, magic);
      |                                  ^~~~~~~~~~~~~~~~~~~
In file included from src/QuickJSEngine.cpp:2:
dep/include/quickjs/quickjs.h: In function ‘JSValue JS_NewCFunctionMagic(JSContext*, JSValue (*)(JSContext*, JSValue, int, JSValue*, int), const char*, int, JSCFunctionEnum, int)’:
dep/include/quickjs/quickjs.h:826:34: warning: cast between incompatible function types from ‘JSValue (*)(JSContext*, JSValue, int, JSValue*, int)’ to ‘JSValue (*)(JSContext*, JSValue, int, JSValue*)’ [-Wcast-function-type]
  826 |     return JS_NewCFunction2(ctx, (JSCFunction *)func, name, length, cproto, magic);
      |                                  ^~~~~~~~~~~~~~~~~~~
src/Prototype.cpp: In member function ‘void Prototype::editScript()’:
src/Prototype.cpp:501:21: warning: ignoring return value of ‘int system(const char*)’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  501 |   (void) std::system(command.c_str());
      |          ~~~~~~~~~~~^~~~~~~~~~~~~~~~~

[JerrySievert]

hm. I don't know anything about supercollider myself, I can only help with general questions and quickjs questions.

I'm not sure who is responsible for the supercollider additions.

[mxa]

I'm puzzled why I am seeing a different output now, I ran the same thing before.

[JerrySievert]

are you trying to build this in a low memory vm maybe?

might try with a fresh checkout, see if you can get repeatable behavior.

[mxa]

It seems like the supercollider engine introduced some undocumented libboost dependencies. Supercollider contributor is not listed in readme. @brianlheim

[JerrySievert]

oof. I think that deserves: https://www.youtube.com/watch?v=yNBFux0ENKc

[mossheim]

I don't maintain this anymore; good luck!

[mxa]

I don't maintain this anymore; good luck!

Fine with me, never the less you should be listed under contributors, I've fixed this now: https://github.com/VCVRack/VCV-Prototype/commit/e3cf3a8d0b90d3fd06e1c609fceed887a10b30e3

[modlfo]

I'm closing this issue since it may be obsolete. I have been able of building QuickJs without issues. If there are still issues related to other engines please create a separate issue or refer to an existing one.