VCVRack / VCV-Prototype

Other
130 stars 22 forks source link

QuickJS exclusive build #63

Closed jpnielsen closed 1 year ago

jpnielsen commented 2 years ago

Managed to build VCV-Prototype 2.3.0 f693e76 on Windows 11 Msys64

Edited Makefile to a QUICKJS only build

DUKTAPE ?= 0
QUICKJS ?= 1
LUAJIT ?= 0
PYTHON ?= 0
SUPERCOLLIDER ?= 0
VULT ?= 0
LIBPD ?= 0
FAUST ?= 0

patched with the changes ( did it manually - I don't know how to merge PR in my local git clone)

https://github.com/VCVRack/VCV-Prototype/pull/58/commits/0dac1aa65b7b02795a533d31200af54d6c6bec9d https://github.com/VCVRack/VCV-Prototype/pull/62/commits/7a3d948d9c95a70382f5ddebecf635647c3f6c8b

make gave errors:

src/Prototype.cpp: In member function 'void Prototype::editScript()':
src/Prototype.cpp:507:49: error: 'toWstring' is not a member of 'rack::string'
  507 |                 std::wstring commandW = string::toWstring(command);
      |                                                 ^~~~~~~~~
make: *** [../../compile.mk:72: build/src/Prototype.cpp.o] Error 1

changed a line src/Prototype.cpp. It's my novice guess as to what replaced string::toWstring - Only tested basic functionality on Windows 11 English.

line 507: std::wstring commandW = string::toWstring(command); changed to: std::wstring commandW = rack::string::UTF8toUTF16(command);

image
squinkylabs commented 2 years ago

probably this is the new version: std::wstring UTF8toUTF16(const std::string& s);

only available for windows (look in string.hpp)

Oh, I read farther, that's exactly what you did. But you will cause problems with non windows builds if you aren't careful.

modlfo commented 1 year ago

The suggested change is already in place. Thanks!