Closed jpnielsen closed 1 year ago
probably this is the new version: std::wstring UTF8toUTF16(const std::string& s);
only available for windows (look in string.hpp)
Oh, I read farther, that's exactly what you did. But you will cause problems with non windows builds if you aren't careful.
The suggested change is already in place. Thanks!
Managed to build VCV-Prototype 2.3.0 f693e76 on Windows 11 Msys64
Edited Makefile to a QUICKJS only build
patched with the changes ( did it manually - I don't know how to merge PR in my local git clone)
https://github.com/VCVRack/VCV-Prototype/pull/58/commits/0dac1aa65b7b02795a533d31200af54d6c6bec9d https://github.com/VCVRack/VCV-Prototype/pull/62/commits/7a3d948d9c95a70382f5ddebecf635647c3f6c8b
make
gave errors:changed a line
src/Prototype.cpp
. It's my novice guess as to what replaced string::toWstring - Only tested basic functionality on Windows 11 English.line 507:
std::wstring commandW = string::toWstring(command);
changed to:std::wstring commandW = rack::string::UTF8toUTF16(command);