Repair team

[AndrewBelt]

The Repair team is the first VCV Community team to launch. The goal is simple: For each open-source plugin in the Plugin Manager, help the developer by sending a pull request that makes it build against the latest master branch of Rack. If you are not quite familiar with GitHub and git, the procedure is the following.

• Make sure to git checkout master and git pull the latest Rack source code, and build it.
• Pick your favorite plugin and click Fork on its GitHub page.
• git clone the forked repo in your plugins/ folder.
• Inspect the code, and apply the changes mentioned in the Plugin API Updates Thread
• Update the form of the Makefile to follow the Template Makefile, including the RACK_DIR which will be useful later.
• Try building it with make -j$(nproc). If you changed everything correctly and it finally builds, make a commit with a message like "Updated to Rack 0.6 API", and git push.
• On your GitHub fork, click "Create Pull Request", and submit it back to the plugin developer.
• After the plugin developer accepts your pull request, you may delete your personal repository.

[cschol]

@hwpfeil Which plugin are you working on?

[ghost]

vcvrackplugins_dekstop also needs RoundSmallBlackSnapKnob. https://github.com/VCVRack/Rack/issues/258#issuecomment-339504994 says to use it, I'm working on vcv. Still placing knobs buried in for loops. Dozens of Small knobs no longer line up. Changed panel heights in Inkscape to avoid scaling errors.

[AndrewBelt]

@hwpfeil No position changes are needed, just a search-and-replace. See https://github.com/VCVRack/Rack/issues/258#issuecomment-372555210

[cschol]

In preparation for the Rack v0.6 release, the plugin versions need to be updated. If your plugin shows up on this list, please update your version to the format

VERSION = 0.6.x (where x is a number from 0 to whatever you want)

in the Makefile in the next few days if possible.

IMPORTANT: Please adhere to this 3-digit versioning format.

If your version is updated or you need assistance with a PR, comment below.

Thank you!

• [x] Alikins 0.6.0dev @alikins
• [x] ArableInstruments 0.6.0dev @adbrant
• [x] AS 0.6dev @AScustomWorks
• [x] CharredDesert 0.6.0dev @JerrySievert
• [x] Stochasm 0.6.0dev @teletypist
• [x] dBiz 0.6.0dev @dBiz
• [x] DrumKit 0.6.0dev @JerrySievert
• [x] FrozenWasteland 0.6.0dev @almostEric
• [x] Gratrix 0.6.0dev @gratrix
• [x] HetrickCV 0.6.0dev @mhetrick
• [x] LOGinstruments 0.6.0dev @leopard86
• [x] luckyxxl 0.6.0dev @luckyxxl
• [x] mental 0.6.a @Strum
• [x] ML_modules 0.6.0dev @martin-lueders
• [x] NauModular 0.6.0dev @naus3a
• [x] Ohmer 0.6.0.4-beta @DomiKamu
• [x] ParableInstruments 0.6.0dev @adbrant
• [x] PvC 0.6.dev @phdsg
• [x] RJModules 0.6.0dev @Miserlou
• [x] squinkylabs-plug1 0.6.0dev @squinkylabs
• [x] SynthKit 0.6.0dev @JerrySievert
• [x] TheXOR 0.6.0dev @The-XOR
• [x] trowaSoft 0.6.5.2dev @j4s0n-c
• [x] ValleyFree 0.6.0dev @ValleyAudio

[squinkylabs]

done! thanks so much.

[LOGUNIVPM]

done, thanks!

[The-XOR]

makefile -> 0.6.0 cheers

[dizzisound]

Additional plugins update: PR for Stochasm merged and closed, courtesy of @teletypist here: Updated to Rack 0.6 API

[mhetrick]

Done. Thanks for the heads up!

[AScustomWorks]

Done!

[JerrySievert]

CharredDesert, SynthKit, and DrumKit all at 0.6.0 - PR's will come soon for this repo for when you're ready to merge/release.

[luckyxxl]

@cschol Done

[almostEric]

Done!

[ValleyAudio]

Done!

[JerrySievert]

is the rack api stable enough to release 0.6.0 binaries in preparation for the release, or are there going to be changes that we should hold off for?

[djpeterso23662]

I have updated MrLumps to VCV Rack 0.6.0 APIs.

[sanderbaan]

Stellare Modular modules are ready for 0.6 :)

[Strum]

done.

[dBiz]

Done ;)

2018-03-16 20:20 GMT+01:00 Dale Johnson notifications@github.com:

Done!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/VCVRack/community/issues/269#issuecomment-373818807, or mute the thread https://github.com/notifications/unsubscribe-auth/AMGJRVpPkETpylrryL3YDIZcc108WA7Xks5tfBCKgaJpZM4SFm1L .

[cschol]

@stellare-modular Thank you! Did you ever figure out the Windows issues? I sent a PR a while ago that should fix those.

[davephillips]

@stellare-modular Is the Turing Machine Music Thing available now for 0.6 ? Just curious, no rush.

[cschol]

@Strum Your latest commit has merge issues.

[sanderbaan]

@davephillips its ready but we release when 0.6 comes out..

[ghost]

I noticed that ParamWidget is now deprecated in app.hpp. Is there a deadline when Param goes away? Existing: addParam(ParamWidget::create Change to: addParam(Parameter::create Will addParam change to addParameter? Easy enough to use [sed -i 's/ParamWidget/Parameter/' *.cpp]

[cschol]

Thank you @chichian!

[AndrewBelt]

@hwpfeil ParamWidget will never go away, but Rack code will refer to it as Parameter from now on. Might as well change back to ParamWidget. I thought the renaming would be more consistent moving forward, but it turned out to not have much of an effect.

[ghost]

Doh! [busy changing it back...] ;-)

[ghost]

Drop-in replacement for "src_float_to_short_array()". For example, in IO-Simple utils/WavWriter.cpp, place the following above WavWriter::run() or in utils/WavWriter.hpp

=-=-=-=-=-snip=-=-=-=- // Excerpts from // SoX Resampler Library Copyright (c) 2007-18 robs@users.sourceforge.net

/// FPU instruction is faster at converting a float to an int, but may not be supported ///#define rint16D(a,b) asm volatile("fistps %0": "=m"(a): "t"(b): "st")

define rint16D(y,x) ((y)=(int16_t)((x) < 0? x - .5 : x + .5))

static __inline int16_t rint16(double input) { int16_t result; rint16D(result, input); return result;}

void src_float_to_short_array(float const src, short dest, int len) { double d, N = 1. + SHRT_MAX; assert (src && dest);

while (len--) d = src[len] * N, dest[len] =
                (short)(d > N - 1? (short)(N - 1) : d < -N? (short)-N : rint16(d));

}

[alikins]

If your plugin shows up on this list, please update your version to the format

Done.

[cschol]

@hwpfeil Can you please explain the licensing implications of what you are proposing in your last post?

[squinkylabs]

@ghost - that looks like the "old fashioned" way to do float to int. I think there are faster and more straightforward ways with SSE, aren't there? Also, it's nice to clamp the values to min/max so overs don't warp around (although current sound card driver does sound pretty terrible if you drive it over +-1).

[MarcBoule]

I've been reading through this issue, and I'm not sure I understand how the 0.6.0 community manifest will work. I saw that there is a v2 branch here https://github.com/VCVRack/community/branches but was wondering if the manifest .json files are still going to be used in 0.6.0? I understand how things worked in 0.5.x w.r.t. the plugin manager and those developper manifest files, but I'm a bit lost here. Is there somewhere specific where someone can point me to read up on how things will work?

I also saw that my plugin is in @cschol 's list near the top (in the plugins not included in the community repo yet), and I was wondering what steps I need to do to get it included in time for the 0.6.0 launch. (also wondering how updates will be handled). Sorry for all the questions! [EDIT: my plugin builds with Rack master and is called ImpromptuModular.]

[AndrewBelt]

@MarcBoule Still haven't planned it, but they will look nearly the same except without the "downloads" property.

[MarcBoule]

Thanks @AndrewBelt . So will the developpers then still need to build the binaries and host them in the developpers' releases, for example, or will the Repair team fork their own copy of our repos in order to build the pluging locally for all three platforms and make those available in the plugin manager for the users? (Discussion related to open source plugins)

[cschol]

@MarcBoule if your plugin is confirmed to be building on all platforms and Makefile (RACK_DIR!) is correct and VERSION is set to 0.6.0, I'll add it later tonight. I'll review and get back with you on any issues if there are any.

[AndrewBelt]

The Build Team (first consisting of just me) will build and host the binaries. The Repair Team and individual developers don't need to do anything.

[JerrySievert]

how, and how often will updates be made? will there be a tag or branch you're looking for to signal an update?

[sebastien-bouffier]

Hello, I see && read many community mails so I set my autistic_mode = OFF and I leave my github repository for a moment to say a very big thanks to the repair team and Andrew for all the efforts and kindness. Such a great piece of software and nice people around it. Cheers.

[AndrewBelt]

@JerrySievert Haven't decided, but I think the best would be for plugin developers to open an issue and the correct team will handle updating your manifest, repo submodule, or build.

[MarcBoule]

Echo that Sebatien, great team indeed, with great volunteers giving their precious time, lead by a beast Andrew Belt who is all over the place driving this tremendous vehicle that is VCV Rack :-) Thanks @cschol for the reply, and thanks AB for the info regarding the build team.

[cschol]

@MarcBoule I added your repository to v2. Thank you for providing the plugin. It looks great! PR will go out later tonight with some other updates. Done.

[ValleyAudio]

@cschol I've noticed that the folder name in v2 for Valley does not match my new slug: Valley

[cschol]

@ValleyAudio Yes, thanks, I will correct that now that your slug has changed. This was because the old one had a whitespace in it.

Update: Repo name has been updated to "Valley" to match the new slug. Going into next PR. Done.

[cschol]

I have filed issues with all developers that have not updated their plugin versions to the three-digit format. This is a reminder ping for developers to get this updated asap. Thank you!

[Strum]

@cschol I think I fixed the merge mess up.

sorry, my bad.

[davephillips]

@cschol Hey Chris, I've been trying to reach you regarding the Peaks module in the Audible Instruments collection. Sorry for using this forum but I can't find another route to you. :) I'd like to get that module in working order and would be happy to help debug it if needed.

[cschol]

@davephillips Let's open an issue in AudibleInstruments for this discussion. I would love to see it included with v0.6, too. It IS working as is, but there was some discussion with Andrew whether the VCV version should work exactly like the physical implementation does. We can continue there. Thanks.

[davephillips]

@cschol I've already opened an issue in Audible Instruments, #49 Peaks build error. Shall we continue there ? If not, please go ahead and open a new one and I'll follow it. Many thanks !

[cschol]

@davephillips Sorry, didn't see that issue. Yes, let's move it there.

[ValleyAudio]

@cschol Was the submodule for Valley updated? Apparently my commits on branch v0.6 are ahead of the submodule