Ohmer - Githubissues

DomiKamu commented 6 years ago

name: Ohmer Modules author: Dominique Camus license: BSD-3-Clause contactEmail: domi.camus@free.fr pluginUrl: https://github.com/DomiKamu/Ohmer-Modules authorUrl: https://github.com/DomiKamu manualUrl: https://github.com/DomiKamu/Ohmer-Modules/blob/master/README.md sourceUrl: https://github.com/DomiKamu/Ohmer-Modules.git donateUrl: https://www.paypal.me/DominiqueCAMUS latestVersion: 0.6.4

mdemanett commented 6 years ago

Hi DomiKamu -- I'm trying to help get everyone requesting a module update unblocked for the review/build process.

With your module, it looks like the code you tagged as 0.6.0 is newer than what went out to package manager. But the package manager version is also called 0.6.0, and the version needs to be bumped before that can update.

Some other devs have the same problem and just need to bump their Makefile version to 0.6.1 to get things rolling. See #356 for more background.

However I see you've got work-in-progress on your master branch -- I imagine you want to finish that before an update goes out? So let us know here when it's ready, and that can be reviewed and queued to go out as 0.6.1.

phdsg commented 6 years ago

@mdemanett looks fixed now

DomiKamu commented 6 years ago

I've wait for many days... stay pending... manual always points to bad link. Now they're updated to 0.6.1 (today) and plugin 0.6.1 is ready. FINISHED Thanks.

DomiKamu commented 6 years ago

How long this release will be published? I don't want to be impatient, but after 5 days, the link to manual remains bad. Can you destroy #423? (I've closed it, sorry, but without clear procedure...). TIA

AndrewBelt commented 6 years ago

Should begin plugin builds by April 4. https://github.com/VCVRack/community/issues/353#issuecomment-377828685

phdsg commented 6 years ago

updated: https://github.com/VCVRack/community/commit/fc3039e89ba76c1cc3cba812a4a66ea43ae37f41

AndrewBelt commented 6 years ago

Updated build.

DomiKamu commented 6 years ago

Thanks Andrew! do I close this issue?

phdsg commented 6 years ago

yes. re-open for any further updates.

DomiKamu commented 6 years ago

Ohmer plugin updated to 0.6.3, thanks in advance to consider it! ;)

DomiKamu commented 6 years ago

Reopened because updated plugin to 0.6.4 (April 28th) - Thanks in advance.

AndrewBelt commented 6 years ago

Updated builds

DomiKamu commented 5 years ago

https://github.com/DomiKamu/Ohmer-Modules.git Lastest commit : 3ecc772f079855ff9bccb5fe96030db4a8b19fd0 Plugin slug: Ohmer Plugin version: 1.0.0

Thanks in advance. Dominique.

(I'm sorry, I've clicked on "Close" button unintentionally.)

AndrewBelt commented 5 years ago

I've made the following patch which fixes the crash in Rack 1.1.2 and released an update with the new version "1.0.0a".

--- a/src/Splitter1x9.cpp
+++ b/src/Splitter1x9.cpp
@@ -274,7 +274,7 @@ struct Splitter1x9Widget : ModuleWidget {
                addOutput(createDynamicPort<DynSVGPort>(Vec(2.5, 220), false, module, Splitter1x9Module::OUTPUT_6, module ? &module->portMetal : NULL));
                addOutput(createDynamicPort<DynSVGPort>(Vec(2.5, 250), false, module, Splitter1x9Module::OUTPUT_7, module ? &module->portMetal : NULL));
                addOutput(createDynamicPort<DynSVGPort>(Vec(2.5, 280), false, module, Splitter1x9Module::OUTPUT_8, module ? &module->portMetal : NULL));
-               addOutput(createDynamicPort<DynSVGPort>(Vec(2.5, 310), false, module, Splitter1x9Module::OUTPUT_8, module ? &module->portMetal : NULL));
+               addOutput(createDynamicPort<DynSVGPort>(Vec(2.5, 310), false, module, Splitter1x9Module::OUTPUT_9, module ? &module->portMetal : NULL));
                // Red LED (used to indicate "clipping" if input voltage is out of bounds).
                addChild(createLight<MediumLight<RedLight>>(Vec(18, 47), module, Splitter1x9Module::LED_CLIP));
        }

This needs to be applied/fixed when you send the next update.

DomiKamu commented 5 years ago

https://github.com/DomiKamu/Ohmer-Modules.git Lastest commit : 3235ef7a348d553050b9b32a3f3067eaad76b337 Plugin slug: Ohmer Plugin version: 1.1.2

Thanks in advance. Dominique.

AndrewBelt commented 5 years ago

Repo submodule should be changed to https://github.com/DomiKamu/Ohmer

DomiKamu commented 5 years ago

https://github.com/DomiKamu/Ohmer Lastest commit: 3f14224acdcc6592d87130e2316022d868f93aaf Plugin slug: Ohmer Plugin version: 1.1.3 Brand: Ohmer Modules

(repo submodule was changed to https://github.com/DomiKamu/Ohmer) Thanks in advance. Dominique Camus.

cschol commented 5 years ago

Mac cross-compile fails: https://github.com/DomiKamu/Ohmer/issues/1

DomiKamu commented 5 years ago

https://github.com/DomiKamu/Ohmer Lastest commit: 9eee42ceb0e9331c5f7c1e280ef7bd390712da40 Plugin slug: Ohmer Plugin version: 1.1.3 Brand: Ohmer Modules

DomiKamu commented 5 years ago

https://github.com/DomiKamu/Ohmer Lastest commit: acdb5a6e90ba0bb3908e3ceab3100288598ae2ed Plugin slug: Ohmer Plugin version: 1.1.3.1 Brand: Ohmer Modules

Thanks in advance!

DomiKamu commented 4 years ago

https://github.com/DomiKamu/Ohmer Lastest commit: dc1de7a2b00d9f31eb05ea4ea643545ca3fd7594 Plugin slug: Ohmer Plugin version: 1.1.6 Brand: Ohmer Modules

Thanks in advance!

cschol commented 2 years ago

Ohmer 2.0.1: 6dfaec5983ced5009402b0b5bcb08baa33255b27

DomiKamu commented 2 years ago

https://github.com/DomiKamu/Ohmer Lastest commit: f21c03ce24124d52d33d9fb739d58500757c2c16 Plugin slug: Ohmer Plugin version: 2.1.0

Thanks in advance!