search

VCVRack / library

Database for the VCV Library
https://library.vcvrack.com/
376 stars 81 forks source link

AS #393

Closed AScustomWorks closed 1 year ago

AScustomWorks commented 6 years ago

Small update to fix some svg file names and custom color for vu meter leds background. Let's see if I got this right:

{
  "name": "AS",
  "author": "Alfredo Santamaria",
  "license": "MIT",
  "manualUrl": "https://github.com/AScustomWorks/AS/blob/master/README.md",
  "sourceUrl": "https://github.com/AScustomWorks/AS",
  "donateUrl": "https://www.paypal.me/frederius/",
  "latestVersion": "0.6.0.1",
  "status": "available"
}
AScustomWorks commented 6 years ago

Another small update (0.6.0.2), BPM clock code fix, VCA internal name fix:

{
  "name": "AS",
  "author": "Alfredo Santamaria",
  "license": "MIT",
  "manualUrl": "https://github.com/AScustomWorks/AS/blob/master/README.md",
  "sourceUrl": "https://github.com/AScustomWorks/AS",
  "donateUrl": "https://www.paypal.me/frederius/",
  "latestVersion": "0.6.0.2",
  "status": "available"
}
AndrewBelt commented 6 years ago

Can I use you as a quick test? Since you created this issue, can you close it and reopen it to make sure GitHub lets you do that? Afterwards, I'll close the issue, and then you check if you can reopen it again.

AScustomWorks commented 6 years ago

done!

AndrewBelt commented 6 years ago

Okay, now try to reopen.

AScustomWorks commented 6 years ago

The reopen button is gone, can't do it

AScustomWorks commented 6 years ago

After you reopened, I can see the close and comment button

AndrewBelt commented 6 years ago

Oh well, I was hoping developers could reopen themselves, but I suppose GitHub disables that for good reason. Since you can comment though, I'll recommend to plugin developers to just make a comment in their closed issue, someone will reopen it, and then someone on the Library Team will handle the request.

mdemanett commented 6 years ago

@AndrewBelt this would be good to go for review/build, if x.y.z.w versions will work (0.6.0.2 here)?

AndrewBelt commented 6 years ago

Yeah, that's fine, although I don't know why plugin developers do it. It could be 0.6.bicycle, as long as it starts with 0.6.

phdsg commented 6 years ago

updated: https://github.com/VCVRack/community/commit/37a08aba782e3f75397d6156e2e89fc62adcb30a

AndrewBelt commented 6 years ago

Removed repo submodule because libsamplerate doesn't build on my Mac build system yet. The fix should not use ./configure but instead a custom libsamplerate build someone puts together. The library's really simple and doesn't need its own build system at all. There are just a couple of source changes required to turn it into a directory of .c and .h files that can be adopted into your build system.

AScustomWorks commented 6 years ago

Agree, but I don't have the slightest idea about where/how to make those changes, just followed your example on Fundamental. Btw. tried with JW's finding, but that still needs the ./configure so not good.

AScustomWorks commented 6 years ago

according to 45f6f7e my makefile should be ok now(made the change the other day, but was not sure about it):

{
  "name": "AS",
  "author": "Alfredo Santamaria",
  "license": "MIT",
  "manualUrl": "https://github.com/AScustomWorks/AS/blob/master/README.md",
  "sourceUrl": "https://github.com/AScustomWorks/AS",
  "donateUrl": "https://www.paypal.me/frederius/",
  "latestVersion": "0.6.0.2",
  "status": "available"
}
AScustomWorks commented 6 years ago

Just curious, is there something still wrong? or maybe it just got forgotten?

AScustomWorks commented 6 years ago

Just updated to AS to v0.6.1, with a new module addition and another module update:

{
  "name": "AS",
  "author": "Alfredo Santamaria",
  "license": "MIT",
  "manualUrl": "https://github.com/AScustomWorks/AS/blob/master/README.md",
  "sourceUrl": "https://github.com/AScustomWorks/AS",
  "donateUrl": "https://www.paypal.me/frederius/",
  "latestVersion": "0.6.1",
  "status": "available"
}
AndrewBelt commented 6 years ago

The Review Team still hasn't updated the repo to fix the libsamplerate build.

phdsg commented 6 years ago

did i not? thought at least the 0.6.0.2 was ready... @AndrewBelt did it fail during pull or make? or did i miss something?

AScustomWorks commented 6 years ago

Made a small fix to BPM Clock module, latest version is now 0.6.2:

{
  "name": "AS",
  "author": "Alfredo Santamaria",
  "license": "MIT",
  "manualUrl": "https://github.com/AScustomWorks/AS/blob/master/README.md",
  "sourceUrl": "https://github.com/AScustomWorks/AS",
  "donateUrl": "https://www.paypal.me/frederius/",
  "latestVersion": "0.6.2",
  "status": "available"
}
AScustomWorks commented 6 years ago

One last update before the next PM build I hope, latest version is now 0.6.3:

{
  "name": "AS",
  "author": "Alfredo Santamaria",
  "license": "MIT",
  "manualUrl": "https://github.com/AScustomWorks/AS/blob/master/README.md",
  "sourceUrl": "https://github.com/AScustomWorks/AS",
  "donateUrl": "https://www.paypal.me/frederius/",
  "latestVersion": "0.6.3",
  "status": "available"
}
mdemanett commented 6 years ago

Updated. Checked the build -- works for me (on mac).

phdsg commented 6 years ago

@AndrewBelt looks like this wasn't this updated in the last cycle. still something wrong?

AScustomWorks commented 6 years ago

Indeed, v0.6.3 still not available on the plugin manager. Do I need to change something?

AndrewBelt commented 6 years ago

libsamplerate can't build on a mingw cross compiler on Linux, because the ./configure step needs to execute built binaries. A fix is to adopt the libsamplerate .cpp files into your own build system and not use the autoconf scripts.

AScustomWorks commented 6 years ago

Thanks Andrew, got rid of libsamplerate and using rack's own samplerate.hpp now so this issue should be resolved finally ;)

latest version is now 0.6.4:

{
  "name": "AS",
  "author": "Alfredo Santamaria",
  "license": "MIT",
  "manualUrl": "https://github.com/AScustomWorks/AS/blob/master/README.md",
  "sourceUrl": "https://github.com/AScustomWorks/AS",
  "donateUrl": "https://www.paypal.me/frederius/",
  "latestVersion": "0.6.4",
  "status": "available"
}
AScustomWorks commented 6 years ago

Now updated to v.0.6.5

phdsg commented 6 years ago

Updated build.

AScustomWorks commented 6 years ago

New module and couple of modifications on two modules. Now updated to v0.6.6

AndrewBelt commented 6 years ago

Updated builds

AScustomWorks commented 6 years ago

3 new modules and a small add on to BPM clock. Now updated to v0.6.7

AScustomWorks commented 6 years ago

Small fixes to 3 modules + new feature added to BPM Calc module. Now updated to v0.6.8

AndrewBelt commented 6 years ago

Updated build

AScustomWorks commented 5 years ago

Fixed some code/added extras on a couple of modules, added 2 new modules. Now updated to v0.6.9

AndrewBelt commented 5 years ago

Updated build

AScustomWorks commented 5 years ago

Fixed some code/added extras on a couple of modules, added 1 new module. Now updated to V 0.6.10

AndrewBelt commented 5 years ago

Updated build

AScustomWorks commented 5 years ago

Added 1 new module (slimmed down BPM Delay/MS calc module). Now updated to V 0.6.11

AndrewBelt commented 5 years ago

Updated build

AScustomWorks commented 5 years ago

Small update: Update on Triggers modules to use pulses. Module name graphic update on BPM Delay/MS calc Now updated to v 0.6.12

AndrewBelt commented 5 years ago

Built updates (yesterday)

AScustomWorks commented 5 years ago

Hi everyone!, Small update: Multi 2x5 module behavior update 2 and 4 channel mixer new modules Now updated to v 0.6.13

AndrewBelt commented 5 years ago

Updated build

AScustomWorks commented 5 years ago

Now updated to V1

cschol commented 5 years ago

Invalid tags in plugin.json: https://github.com/AScustomWorks/AS/issues/41

cschol commented 5 years ago

Plugin crashes module browser: https://github.com/AScustomWorks/AS/issues/42

cschol commented 5 years ago

Plugin still crashes in other instances. See issue AS#42 for updates.

AScustomWorks commented 5 years ago

Hi, now updated to V 1.0.1

Fixed Slug names on TinySine and TinySawish(LowerCase error) SignalDelay snd port with pre/post delay switch Small graphic refresh/fixes, output ports on every module are now gold colored to make easier to find them

AScustomWorks commented 5 years ago

Hi everyone! the plugin is updated to V 1.0.2 now

More graphic updates. Now every knob tooltip shows the proper parameter value according to it's function. BPM Clock got the BPM range switch removed to work ok with the tooltips, 30-300 BPM is now the default range.

AScustomWorks commented 5 years ago

Hi everyone! the plugin is updated to V 1.0.3now.

Updates: BPM Calc and BPM Calc 2: small code optimization. Delay Plus Stereo FX: Now when the Feedback or Color channels are linked, the right knob reflects the setting from the left knob. Super Drive FX Stereo module added WaveShaper module: CV inputs to control shape and scale added, wave mod input added. WaveShaper FX Stereo module added, same features as WaveShaper, but stereo.

AScustomWorks commented 4 years ago

Hi everyone! the plugin is updated to V 1.0.4 now. Update: fixed the "disabled" property on the plugin.json file

AScustomWorks commented 2 years ago

Hi, AS plugin is ready for V2 Also made an update for V1 to v1.05(Phaser bleed bug fixed - ZCV2T polyphony update )just incase you are still updating the V1 plugins. Thanks!