Bogaudio

[mdemanett]

Requesting an update of Bogaudio.

updatedVersion: 0.6.5

[phdsg]

updated

[phdsg]

@AndrewBelt was there something wrong building this?

[AndrewBelt]

@phdsg It was actually a problem with my own build script.

Updated build, close until you have a new update.

[mdemanett]

Checked and the build came through the package manager on my non-dev Rack -- very cool.

Thanks!

[mdemanett]

New modules.

Version: 0.6.6 Hash: f8e617fc760a89c30d29632d7d7fc205215e64cc

@AndrewBelt is it cool if we who are on the review team update ourselves, or should we keep it legit and wait for another on the team to do it? If the latter, @phdsg would you do me the honor?

[AndrewBelt]

@mdemanett Yeah, another Review Team member should review it. You can update your own information though (be your own Library team).

[phdsg]

@mdemanett oh damn, missed that mention. top of the list now. probably later today.

[mdemanett]

Thanks!

[mdemanett]

New release.

Version: 0.6.7 Branch: master

@phdsg any chance you could review? Thanks!

[AndrewBelt]

What's the git command(s) you use to compare the current commit in a submodule with a new commit? Is it something like git fetch; git diff HEAD <commit id>?

[mdemanett]

I do this:

cd repos/<whatever>
git pull origin master   ...if they're on master
  ...part of the output here is: "Updating hash...hash", I copy "hash...hash"
git diff <paste the hash...hash>

There's probably an easier way, but that does produce a diff of just what's changed since the last time the submodule hash was updated.

I actually usually do git diff hash...hash Makefile src to focus on the interesting bits (and exclude .svgs), after checking if all the sources are actually under src.

[AndrewBelt]

Yeah, there's probably a better method, but that works. Reviewed and built.

[mdemanett]

Thank you.

[mdemanett]

New release...

0.6.8 aa0cd8588c372e9450ea47a4f199cb0d5ab4f9e3

Thanks!

[cschol]

I never realized that Bogaudio was you. Some of my very favorite modules. :)

[AndrewBelt]

Same, I use them regularly and put them on the Knobcon poster. https://twitter.com/vcvrack/status/1038953900211097600

[mdemanett]

Thank you both, that's great to hear. Glad you like em.

I saw that image at the time but didn't look closely -- that's awesome!

[AndrewBelt]

Updated build

[mdemanett]

Requesting a bug fix update.

0.6.9 02f5852cb808ddd4d4c0dfd4097b4c46912717d8

Thanks!

[AndrewBelt]

Updated build

[mdemanett]

Another bug fix version.

0.6.10 44d51ceb3f63fadb92b6541b0fa8b731e0b31076

Thanks.

[AndrewBelt]

Updated build

[mdemanett]

Some new stuff:

0.6.11 b8ab74bea92de2ff6f40249a8a6a184f79ec15c0

Thanks!

[cschol]

I'll review yours if you review mine (modular80). ;)

[mdemanett]

Done and done!

[AndrewBelt]

Updated build

[mdemanett]

Bug fix.

0.6.12 8026812acd0e8fbba70b756b3f4d93e95e877aea

Thanks.

[AndrewBelt]

Updated build

[mdemanett]

More stuff.

0.6.13 e61b051fd5926a85ae141a7c9208708dd1a98cbb

Thanks!

[AndrewBelt]

Build error on Linux. I think one of those values needs to be cast to double or float.

g++ -Isrc -Isrc/dsp -Wsuggest-override -std=c++11 -DSLUG=Bogaudio -DVERSION=0.6.13 -DSLUG=Bogaudio -fPIC -I/Rack-SDK/include -I/Rack-SDK/dep/include -DVERSION=0.6.13 -MMD -MP -g -O3 -march=nocona -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_LIN -c -o build/src/dsp/filter.cpp.o src/dsp/filter.cpp
src/dsp/signal.cpp: In member function 'float bogaudio::dsp::Limiter::next(float)':
src/dsp/signal.cpp:401:42: error: no matching function for call to 'min(double, float&)'
    out = std::min(fabs(sample) - _knee, x);
                                          ^
In file included from /usr/include/c++/5/algorithm:61:0,
                 from src/dsp/signal.cpp:3:
/usr/include/c++/5/bits/stl_algobase.h:195:5: note: candidate: template<class _Tp> const _Tp& std::min(const _Tp&, const _Tp&)
     min(const _Tp& __a, const _Tp& __b)
     ^
/usr/include/c++/5/bits/stl_algobase.h:195:5: note:   template argument deduction/substitution failed:
src/dsp/signal.cpp:401:42: note:   deduced conflicting types for parameter 'const _Tp' ('double' and 'float')
    out = std::min(fabs(sample) - _knee, x);
                                          ^
In file included from /usr/include/c++/5/algorithm:61:0,
                 from src/dsp/signal.cpp:3:
/usr/include/c++/5/bits/stl_algobase.h:243:5: note: candidate: template<class _Tp, class _Compare> const _Tp& std::min(const _Tp&, const _Tp&, _Compare)
     min(const _Tp& __a, const _Tp& __b, _Compare __comp)
     ^
/usr/include/c++/5/bits/stl_algobase.h:243:5: note:   template argument deduction/substitution failed:
src/dsp/signal.cpp:401:42: note:   deduced conflicting types for parameter 'const _Tp' ('double' and 'float')
    out = std::min(fabs(sample) - _knee, x);
                                          ^
In file included from /usr/include/c++/5/algorithm:62:0,
                 from src/dsp/signal.cpp:3:
/usr/include/c++/5/bits/stl_algo.h:3445:5: note: candidate: template<class _Tp> _Tp std::min(std::initializer_list<_Tp>)
     min(initializer_list<_Tp> __l)
     ^
/usr/include/c++/5/bits/stl_algo.h:3445:5: note:   template argument deduction/substitution failed:
src/dsp/signal.cpp:401:42: note:   mismatched types 'std::initializer_list<_Tp>' and 'double'
    out = std::min(fabs(sample) - _knee, x);
                                          ^
In file included from /usr/include/c++/5/algorithm:62:0,
                 from src/dsp/signal.cpp:3:
/usr/include/c++/5/bits/stl_algo.h:3451:5: note: candidate: template<class _Tp, class _Compare> _Tp std::min(std::initializer_list<_Tp>, _Compare)
     min(initializer_list<_Tp> __l, _Compare __comp)
     ^
/usr/include/c++/5/bits/stl_algo.h:3451:5: note:   template argument deduction/substitution failed:
src/dsp/signal.cpp:401:42: note:   mismatched types 'std::initializer_list<_Tp>' and 'double'
    out = std::min(fabs(sample) - _knee, x);
                                          ^

[mdemanett]

Weird...it worked on my linux test box (ubuntu, gcc 7.2).

So anyway, this is a blind fix but fingers crossed: da503df0fc49576bf6f9c5d6378412454444d5ca

Thanks again!

[cschol]

Tested in Ubuntu 18.04 (gcc 7.3.0) and Docker image based on Ubuntu 16.04 (gcc 5.4.0). Compiled fine in both cases with the latest changes.

[AndrewBelt]

Updated build

[mdemanett]

New stuff.

30fe5fe6a5ccb271d823eee3b3f1f199e9b8aa79 0.6.14

Thanks!

[AndrewBelt]

Updated build

[mdemanett]

New stuff! And fixes.

eac5dbde180c37b2a793f74326e0a3aaa500b75a 0.6.15

Much thanks....

[mdemanett]

D'oh, last build crashes. Here's the fix.

I guess people really use this stuff; the crash was reported within an hour of the build going out.

0.6.16 f7fb7aed31bf98b7e1f0a496d5ef43b3d9488ac9

Thanks again.

[mdemanett]

Ready for v1.

1.0.17 acad9b012127a88b4bcb42e80a79ad69568ee131 master branch

Thanks!

[cschol]

plugin.json issues: https://github.com/bogaudio/BogaudioModules/issues/62

[mdemanett]

Bug fixes...

1.1.18 ff516914ccc192439716ee96acfba4abc8a023b2

Thanks!

[mdemanett]

Another fix...

1.1.19 efb0556c0282672564e5f3fded7801473a782d7f

Thanks again.

[mdemanett]

Still more fixes....

1.1.20 592aead62e76e1a3f87dae213007ddfb8c4a826d

Thanks again!

[mdemanett]

Even more fixes.

1.1.21 c221b53171a3603e48551f1c8f644e3020b69398

Thanks!

[mdemanett]

Minor feature...

1.1.22 bfcd725febd617d0034293f37e0d872f2e16b1bc

Thanks!

[mdemanett]

Poly support, finally....

1.1.23 5fc0abec62cb0869484d33c13e6ba84d6985759c

Thanks!

[cschol]

Compile failures against 1.1.6 SDK: https://github.com/bogaudio/BogaudioModules/issues/76

[mdemanett]

Compile failures against 1.1.6 SDK: bogaudio/BogaudioModules#76

Doh. Fixed in a78cb4a4e3656efbcf4272ac0231657dd3b56034

[mdemanett]

Fixes release.

1.1.24 bdcb12dca7624752f0f69d9c680ca0ccaee30dde

Thank you.

[mdemanett]

Requesting another build here...fixes a crash.

1.1.25 e9a38d3a308c6eddb35a819e0d5449f181aec712

As always thanks!

[mdemanett]

New stuff...

1.1.26 43669fe4f13d6708173f65345b33ba12643c5608

Thank you!