VCVRack / library

Database for the VCV Library
https://library.vcvrack.com/
385 stars 82 forks source link

Mental #458

Closed Strum closed 2 years ago

Strum commented 6 years ago

Mental modules community thread

Strum commented 6 years ago

Mental Modules By Strum strum@softhome.net Version 0.6.1 License BSD 3 Code : https://github.com/Strum/Strums_Mental_VCV_Modules Manual (work in progress) : https://github.com/Strum/Strums_Mental_VCV_Modules/wiki

Strum commented 6 years ago

I've made a bunch of changes and need a new release built please.

Version : 0.6.2

Changes are on the Master branch

This is the Hash ( i think ):

2bd3cfa43c21c13258b62bbb66743c286bf8c5fd

Thanks.

AndrewBelt commented 6 years ago

@mdemanett You've mistakenly set "latestVersion", instead of repoVersion. Reverted your commit. Reaction: https://www.facebook.com/groups/vcvrack/permalink/177026399624179/

Strum commented 6 years ago

@AndrewBelt,

What happened there?

Is there something I need to change?

I realised I'd forgotten to add some graphics to the res folder, thought git added them automatically, updated hour or so ago, should all be there now.

phdsg commented 6 years ago

@mdemanett let's pause here before a new try. i recommended to Strum to purge his git history from old zips and stuff (~100mb).

Strum commented 6 years ago

@mdemanett @phdsg

Sorted, should be ready to go.

phdsg commented 6 years ago

had a bit of a struggle with the changed history and syncing/fetching and then broke the repo for a few minutes, but i think it's fixed now.

mdemanett commented 6 years ago

Sorry about that...@phdsg thanks for fixing!

phdsg commented 6 years ago

Updated build.

Strum commented 6 years ago

I'm really sorry guys but I made a cock up with one of the background graphics and had to rescale it.

It's the MedKnob.svg in /res/components, no changes to the code you can just overwrite that file without rebuild the .dll

Sorry again, I'll test more thoroughly in future.

Cheers

AndrewBelt commented 6 years ago

Updated builds

Strum commented 6 years ago

@AndrewBelt , thanks Andrew, sorry again, I am slowing learning though :)

cschol commented 5 years ago

plugin.json issues: https://github.com/Strum/Strums_Mental_VCV_Modules/issues/45

Strum commented 5 years ago

OK .json fixed, let me know if there are any further issues

Strum commented 5 years ago

Update ready, on the master branch.

cschol commented 5 years ago

make dist fails: https://github.com/Strum/Strums_Mental_VCV_Modules/issues/52

Strum commented 5 years ago

@cschol , oops, sorry, forgot about that, removed the demo patches and am moving them to the wiki. sorted now.

Strum commented 4 years ago

Fixed json issue updated version to 1.0.2

Strum commented 3 years ago

Hi,

I've made an update finally, new code is on the 103_update branch.

Thanks

Strum

Strum commented 3 years ago

New version 1.0.3 Commit Hash : 7f1cf3807d226786e8537c0a7c7bed3de1838d75

cschol commented 2 years ago

@Strum it looks like you have changed the module slugs in this version. Unfortunately, that is not allowed since it breaks backwards compatibility with patches created with previous versions. Please revert the module slug changes and resubmit. Thanks.

Strum commented 2 years ago

Andrew had asked me to make those changes. Given there have been a number of updates in the past that have broken old patches I find it a bit strange developers are now concerned about it. Perhaps you could talk to Andrew about it.

Cheers

Strum

AndrewBelt commented 2 years ago

@Strum I don't remember asking you to make changes, but plugin and module slugs can't be changed once submitted to the VCV Library. However, you can change plugin or module names. See https://vcvrack.com/manual/Manifest for a reference of these properties.

Strum commented 2 years ago

text of your emails on the subject

Hello, I'm emailing to suggest the following changes to your plugin manifest for your plugin's next update, at your convenience/discretion.

Your plugin URL on the VCV Library: https://library.vcvrack.com/Mental Reference for the plugin.json file: https://vcvrack.com/manual/Manifest Instructions for requesting an update to the VCV Library: https://github.com/VCVRack/library#adding-your-plugin-to-the-vcv-library-for-open-source-plugins

Andrew Belt VCV https://vcvrack.com/

Hi, I noticed the brand of your plugins is "Strum's VCV Modules". I'd prefer that the name "VCV" is left out since it's a trademarked name. But regardless, it probably makes more sense to set the brand to "Mental" and remove the "Mental" string from all module names. That way, instead of the full module name being "Strum's VCV Modules MentalMuxes", it would be "Mental Muxes" which is cleaner and more organized. See https://github.com/VCVRack/library#vcv-library-database for requesting an update to the VCV Library.

Best, Andrew Belt VCV https://vcvrack.com/

AndrewBelt commented 2 years ago

Those suggestions are still valid, but they apply to names, brands, etc. The slugs should remain unchanged to maintain patch compatibility.

cschol commented 2 years ago

Closing until plugin is updated.

Strum commented 2 years ago

Sorry it's taken me a while to get back to this.

Will leave names as they were.

The basic update to get them working in version 2 is done, it's on the 200_update branch.

I'm working on adding the tool tips for another update and should get that done in the next week or 2.

Let me know if you have any further issues.

Cheers

Strum

cschol commented 2 years ago

Caching font references crashes VST: https://github.com/Strum/Strums_Mental_VCV_Modules/issues/57

Strum commented 2 years ago

Thanks,

Sorry about that, I hadn't tested it with VST, will fix as soon as I can.
Strum commented 2 years ago

Okay, think I've fixed it, hope it's right this time.

Strum.