search

VCVRack / library

Database for the VCV Library
https://library.vcvrack.com/
375 stars 81 forks source link

unless_modules #460

Closed unlessgames closed 8 months ago

unlessgames commented 6 years ago

{ "name": "unless modules", "author": "unless games", "license": "BSD-3-Clause", "authorEmail": "unlessgames@gmail.com", "pluginUrl": "https://gitlab.com/unlessgames/unless_modules", "authorUrl": "http://unlessgames.com", "manualUrl": "https://gitlab.com/unlessgames/unless_modules/blob/master/README.md", "sourceUrl": "https://gitlab.com/unlessgames/unless_modules", "latestVersion": "0.6.1" }

latest commit hash : de0f52eef920f27e404f08285862ef72f6528c21 branch : master

phdsg commented 6 years ago

@unlessgames nice module ;) entry here needs a little fix tho. license says BSD-3-Clause, https://gitlab.com/unlessgames/unless_modules/blob/master/LICENSE.txt says it's MIT.

unlessgames commented 6 years ago

thank you! it should be fixed now..

unlessgames commented 6 years ago

but then isn't the LICENSE.txt in the Fundamental plugin contains MIT text while the plugin said to be under BSD? I've been copying that file iirc. sry if I'm just being confused.

AndrewBelt commented 6 years ago

You can license your code however you want. We just needed to verify the conflicting information between your post and your LICENSE.txt file.

phdsg commented 6 years ago

i've added it with the commit after you changed it to BSD-3-Clause in your repo, so all fine i think.

unlessgames commented 6 years ago

thanks all for such fast progress!

phdsg commented 6 years ago

Updated build. please close this issue until there's a new update.

unlessgames commented 6 years ago

hello! I've added a new module: Mr.Chainkov latest commit hash : afc135337d86674da5e7c6a32e510e3ea2328ad3 latestVersion -> 0.6.2 thank you!

AndrewBelt commented 6 years ago

Updated build

unlessgames commented 4 years ago

hi! resurrecting my plugin! repo is still at gitlab.com/unlessgames/unless_modules

latest commit hash : b4fcd238dd99b0e8aa1a278eab4b7ed04b0d7ea1

is this ok as migration to v1?

unlessgames commented 4 years ago

thanks for reopen! in the meantime fixing some "uint" to "unsigned int" for other than my compiler. latest commit hash : 2b5af14e92bea61dc7686269aa3cec339f87ec07

unlessgames commented 4 years ago

fixing a mistake in mr chainkov new hash : 287bd9542a26dfade1049f23b73c6e17e21f90fc

unlessgames commented 4 years ago

changed some tags in plugin.json to v1 format

9638a26434acf7460206b78809eacb3ac9ddcfbb

unlessgames commented 4 years ago

adding a dark theme to mr.chainkov

663c75b0e351f01d2d6fdf49f640bc4e5eee2060

unlessgames commented 4 years ago

fixing some things that came up on the forum

01671281a0b51ad0b34d6f6bf02b1e359d372c07

cschol commented 4 years ago

Two issues found in the plugin.json:

Invalid URL: https://unlessgames.com/
Invalid license ID: LGPL
-- License must be a valid Identifier from https://spdx.org/licenses/
unlessgames commented 4 years ago

should be sorted now!

unlessgames commented 4 years ago

sorry, closed by mistake.

unlessgames commented 4 years ago

hi!

I have an anniversary update to pull with 4 new modules! It's been a year since I started with creating modules, this one contains another game emulator to celebrate that and some more! Thank you for everything!

latest commit is 226423f7b5a57e59170bd73d11805384817aee08

unlessgames commented 4 years ago

latest is 9134e6cdfbe4411169b15548991f5b4b3eae387c

possibly fixing a bug that came up on the forum.

maybe this should be on hold until they say it solves it.. sorry, guess I should post the source updates to the forum before here.

cschol commented 4 years ago

No worries. I won't integrate until you let me know.

unlessgames commented 4 years ago

apparently it's ok now! thanks!

unlessgames commented 4 years ago

or it is ok now..

8e6046bf3b12052d8e9ff29064aea32758d691ba

cschol commented 4 years ago

Build failure on Mac:

src/snake.cpp:825:21: src/towers.cpp:350:20: error: reference to 'string' is ambiguous
      item->text = string::f("%d", c);                                                                                                                                                                                                                                                                                
                   ^
/home/cschol/src/osxcross/target/bin/../SDK/MacOSX10.13.sdk/usr/include/c++/v1/iosfwd:194:65: note: candidate found by name lookup is 'std::__1::string'                                                                                                                                                              
typedef basic_string<char, char_traits<char>, allocator<char> > string;
                                                                ^
/home/cschol/src/Rack-SDK/Rack-SDK/include/string.hpp:11:11: note: candidate found by name lookup is 'rack::string'
namespace string {
unlessgames commented 4 years ago

should be fixed now!

6be2c748a4acb0cf38392824410d67090d76611b

unlessgames commented 3 years ago

hello! I have an update with some fixes and features!

latest commit is 900c5a95c31e211def98607165cd348097906dac

danke!

unlessgames commented 2 years ago

Hello!

Got an long overdue update for v1 and also v2.

Reworked the licensing in the added LICENSE.md but unsure if I should have two licenses listed in plugin.json or not. any suggestions?

Do I submit v2 modules here as well?

latest v1 branch commit 4019ae40b48b8c4b8c31d70b96f08a4bd3921b9d

latest v2 branch commit 8c059b43a2b47da471b4eda72dafe9014647d382

Thanks!

cschol commented 2 years ago

Issues in plugin.json for both versions v1 and v2:

[unless_modules] Validating plugin.json...FAILED
[unless_modules] Issues found in `plugin.json`:    

pianoid: invalid module tags: Polyhonic             
-- Valid tags are defined in https://raw.githubusercontent.com/VCVRack/Rack/v2/src/tag.cpp
Invalid license ID: CC-BY-NC-ND, GPL-3
-- License must be a valid Identifier from https://spdx.org/licenses/

We only support one license in the field. Just use the appropriate GPLv3 license ID in the license field.

Yes. v2 modules are submitted here as well. Thanks!

unlessgames commented 2 years ago

Alright, issues fixed!

v1 9e24b9808b644f5e96fd2e55ac02feb9a6a82a09 v2 c2ca59928a28fc3700d18810530d11be97ed3c51

btw is this validator available for use? It would be cool if I could run it before submitting to avoid future typos.

cschol commented 2 years ago

Sorry, the license ID is invalid.

[unless_modules] Validating plugin.json...FAILED                                                                                                                                                                                                                                                                      [unless_modules] Issues found in `plugin.json`:

Invalid license ID: GPL-3
-- License must be a valid Identifier from https://spdx.org/licenses/

See here for the validation script: https://github.com/cschol/rack-library-tools

unlessgames commented 2 years ago

My bad! Fixed now.

v1 cc56599fc5bce90745338694543449099b9ff331 v2 4bbf174ab1f39db0536ad1aa5e0c94dd473f2b23

Validated with your tool :) Thanks!

cschol commented 2 years ago

Works. Thanks for testing the tool.

unlessgames commented 2 years ago

Hello!

I've fixed some bugs and have a new version for the v2 branch

commit : 7cebaf0a6bc6bb1d49d7fa919f1490897d3b7c10

Thanks!

unlessgames commented 2 years ago

I'm sorry, found another bug since then which needed fixing.

current commit is

040a0648bd77c109739afd8970868ec5e780265b

unlessgames commented 10 months ago

Hello!

I have an update fixing some memory issues.

Commit is

5a9a1727436f95fbe28e77fcd91e38e38418a58f

cschol commented 10 months ago

I don't have a Gitlab account so posting issues here.

Static analysis with CodeQL and cppcheck found a few more issues:

CODEQL ISSUES FOUND:
"Static array access may cause overflow","Exceeding the size of a static array during write or access operations may result in a buffer overflow.","warning","Potential buffer-overflow: 's' has size 8 not 9.","/src/theme.hpp","76","17","76","17"
"Badly bounded write","Buffer write operations with a length parameter that does not match the size of the destination buffer may overflow.","error","This 'call to snprintf' operation is limited to 9 bytes but the destination is only 8 bytes.","/src/theme.hpp","76","5","76","12"

Running cppcheck analysis...
src/theme.hpp:76:14: error: Buffer is accessed out of bounds: s [bufferAccessOutOfBounds]
    snprintf(s, 9, "%02x%02x%02x%02x", colorVal(c.rgba[0]), colorVal(c.rgba[1]), colorVal(c.rgba[2]), colorVal(c.rgba[3]));
             ^
src/_arth.hpp:546:12: error: Uninitialized variable: art.widget_count [uninitvar]
    return art;
unlessgames commented 10 months ago

Hey, the buffer issue pointed to a function that was never called, but I commented it out.

Couldn't reproduce the second warning and I don't see how the variable could be uninitialized as it is done so in its declaration. I've put in another explicit assignment where the struct is created, maybe it solves the warning?

Is there any specific flag or something you are running cppcheck with?

I don't have CodeQL so I can't check that but I assume both warnings came from cppcheck anyways. (EDIT: I realize CodeQL was reporting the first two lines but they were about the same thing)

Thanks!

last commit b91d953ba545dd92220efd91f922759f18425c56

cschol commented 10 months ago

All the warnings are now resolved with the latest changes.

Not running any special cppcheck flags:

cppcheck src/ -isrc/dep --std=c++11 -j 8 -q --error-exitcode=1
unlessgames commented 8 months ago

Hey, I have an update with a bug fix and resolving deprecations.

Latest commit is

0106e455400a9e8bf3bbbb0abde4418e7614c5aa