Closed freddyz closed 2 months ago
Fantastic thanks! Curious - what do I need to do to allow users to add my plugins via the plugin manager interface (ie with the "+Free" green button)?
As soon as Andrew updates the build, the plugin will show up in the Plugin Manager. My commit stages your plugin for inclusion in the build process. Nothing more for you to do.
@AndrewBelt Did this get missed in the last build update?
I never did a build update.
But looking at this, I can't accept it because of the dist/
and plugin.dylib
files. @freddyz
needs to remove those from git history, not by making a commit, and I'll build.
@AndrewBelt I believe I have successfully removed the dist/ and plugin.dylib files from my repository's git history. Thank you for the clear description of the problem and instructions!
Perhaps I should mention that I did make one commit to the repo after removing the dist/ and plugin.dylib files. It was just to alter the gitignore file. Latest commit is at: d7a4d60ce8147cd8c12b10a4b4983c85d7196dc6
@cschol Could you update this? He correctly removed the commit pointed to by the submodule, but now the new commit needs to be used.
Sorry, been out of town this week for work. I see Matt made the commit. Thanks!
Updated build
@AndrewBelt Something is wrong with the computerscare
module (tested on Linux and Mac, both fail to download when launching Rack and hitting Update).
[4.811 info src/plugin.cpp:199] Downloading plugin computerscare 0.6.2 lin
[5.100 warn src/plugin.cpp:204] Plugin computerscare download was unsuccessful
Thanks, forgot to sync the package directory.
Kindly requesting an update to Computerscare Modules, now at version 0.6.3 Latest commit hash: 55e4987c1a8cf56a992d2c91d08ab5b986a1a739 Repository URL: https://github.com/freddyz/computerscare-vcv-modules/
Updated build
Requesting an update to Computerscare Modules, now at version 0.6.4 Latest commit hash: d41bece8fcdd35441c3e45e3d906ee75d5fe75b7 Repository URL: https://github.com/freddyz/computerscare-vcv-modules/
Thank you!!!
Built updates (yesterday)
Requesting an update to Computerscare Modules, new version: 0.6.5 Latest Commit hash: f39e214e99d9a0682af1f4d69c00db4bb298f8f5 Repository URL: (https://github.com/freddyz/computerscare-vcv-modules/)
Thanks much!
Updated build
Bugfix: Requesting an update to Computerscare Modules, new version: 0.6.6 Latest Commit hash: 6fb5c5dc0a35ed09a8af81ffe4e23dd6a542b6b2 Repository URL: (https://github.com/freddyz/computerscare-vcv-modules/)
Updated build
Requesting review & update of computerscare modules, new version:1.0.0 Latest commit hash: 48e7dcc53e928e3bafa15051d64fd6a4b3dc1023 (master branch) Repository: https://github.com/freddyz/computerscare-vcv-modules
Thank you!
Invalid tag in plugin.json
: https://github.com/freddyz/computerscare-vcv-modules/issues/15
Fixed the invalid tag.
New hash: 238ff6e44286f2f54b24d3ac30c34ca368d95471 on master branch
Requesting an update to computerscare modules, new version 1.0.3 Last commit hash: 6cb2ee065d911ceef864efa26f6633c4a72f3ba9 Repository URL: https://github.com/freddyz/computerscare-vcv-modules
Thanks - have a nice day!
Requesting a build update for computerscare modules, new version 1.1.0 Last commit hash: bfbc782f2787c6eadf6855a396e887a6ceab9b40 Repository URL: https://github.com/freddyz/computerscare-vcv-modules
Thanks much!
Build error on Linux.
src/ComputerscareLaundrySoup.cpp:99:46: error: array must be initialized with a brace-enclosed initializer
bool activePolyStep[numFields][16] = {false};
^
Suggest using = {{false}};
@AndrewBelt Are you still running Ubuntu 16.04? I might have to create a Docker container to catch this (I'm on 18.04).
I believe I have fixed the Linux build error (thanks @AndrewBelt)
New release candidate for computerscare modules 1.1.0: hash: 27c7384627b8421753542c552845df0d1a92864d Repository URL: https://github.com/freddyz/computerscare-vcv-modules
@cschol Yes, specifically because it uses the minimum supported glibc and libstdc++ versions.
Terribly sorry for this, but I just noticed a pretty bad bug I introduced with this 1.1.0 update (last hash without the problem is 6cb2ee065d911ceef864efa26f6633c4a72f3ba9, which is the version currently in the plugin manager). Is there any way that my changes to computerscare modules 1.1.0 could NOT be included in the coming library update? Ideally this issue would be "closed", and I will make a comment when I've fixed the problem and then it can go through the regular review process.
If it's too late - that is okay but I thought I'd ask anyway!
No problem. I rolled back the pinned repo version to 1.0.3. Closing this issue until the next update.
@AndrewBelt FYI, in case this build gets triggered anyway (which it should not, since it is up to date with the currently available version).
Requesting an update:
computerscare modules, new version: 1.1.1: hash: 77e8e973e7b552add8d82bf70f8dc80dc1f053f4 Repository URL: https://github.com/freddyz/computerscare-vcv-modules
Cheers!
Requesting an update to Computerscare Modules new version: 1.2.0 commit hash: d0dddec16c3f36d86d3cd5c061a4940c5c7028c0 repository: https://github.com/freddyz/computerscare-vcv-modules
Kindly requesting an update to Computerscare Modules new version: 1.3.0 commit hash: c1d03abafa454cc357abab7fb0aaf5a9491691de repository: https://github.com/freddyz/computerscare-vcv-modules
Have a nice day!
Requesting an update to Computerscare Modules new version: 1.4.0 commit hash: 055532aad3a63f66d064660d095d61aea6ea6201 repository: https://github.com/freddyz/computerscare-vcv-modules
This commit is NOT to the master branch. I believe this is not a problem but mentioning just in case.
Love, Adam
Requesting update to Computerscare Modules New version: 1.4.1 commit hash: c5dbc6d14961e930450b255a56afab28e6374f5e repository: https://github.com/freddyz/computerscare-vcv-modules
Thank you!
Kindly Requesting update to Computerscare Modules New version: 1.4.2 commit hash: f8e7b10e8b37a7f329f355d454e7aebed4b5cb5b repository: https://github.com/freddyz/computerscare-vcv-modules
Thanks much!
Requesting update to Computerscare Modules New version: 1.4.3 commit hash: 46de839256bab5ff44505b0a8ebbb15364aaa514 repository: https://github.com/freddyz/computerscare-vcv-modules
Thank you very much
Requesting update to Computerscare Modules for v2 New version: 2.0.1 commit hash: aa0bc12b15cc870125c3652ffb4e232078df4ec9 repository: https://github.com/freddyz/computerscare-vcv-modules
Thanks!
Can you please check if you pushed the changes? This SHA is not in the repository (yet).
Ah, OK. Apparently, git fetch --all
does not fetch tags and I need git fetch --tags
. All good.
Earlier today I commented requesting a build update but since found a critical bug on Windows. Withdrawing prior request for now.
Requesting update to computerscare modules New version: 2.1.11 commit hash: 57d341db9fc0ecf8e4b61cc917ecafda8c5096ee repository: https://github.com/freddyz/computerscare-vcv-modules
@cschol @AndrewBelt This release candidate v2.1.11 is stable and ready to be added to the Library at your convenience. Thanks much!
2 new VCV Rack modules: "Father & Son Patch Sequencer" and "Debug". I believe this is the required information for inclusion in the Plugin Manager:
Apologies if I'm missing some things - this is my first time going through this process. Thank you!