Open Coirt opened 5 years ago
Build failure on Linux: https://github.com/Coirt/Bark/issues/10
Updated make file there. Hows this look?
RACK_DIR ?= ../..
SLUG = Bark
VERSION = 0.6.3
FLAGS +=
SOURCES += $(wildcard src/*.cpp)
DISTRIBUTABLES += $(wildcard LICENSE*) res
# Include the VCV Rack plugin Makefile framework
include $(RACK_DIR)/plugin.mk
Looking good. Thank you for fixing.
I'll get the whiskey so...
Updated build
manifest update: https://github.com/Coirt/Bark/blob/0.6.3/Bark.json
Same version just added a donate link
"donateUrl": "https://www.paypal.me/philgolden",
Manifest is updated. Link is available on the Plugin website.
Master now at v0.6.4
Just rediscovered a bug I thought I had fixed.
EDIT: Think I fixed it, so should be good to go as is.
Nah didn't fix it I have the trigger for the bug disabled, so as is!
VERSION
in Makefile
needs to be updated to 0.6.4.
Makefile is 0.6.4. Thought I defaulted master to 0.6.4 seems not the case.
I'll try that again... Master now 0.6.4
The Makefile in the 0.6.4
tag is still at 0.6.3. I am using the HEAD of master
.
Updated build
Don't know what is going on with updating panels to github. I've updated the TrimLFO panel twice and the same panel (original upload) is still in the repo. Updated the One Band panel also the exact same way and the larger sized dev version updated fine.
Anyway... I will delete the Trim panel and upload a new panel to master. Will that change take effect or will it require a new version in order for clients to update?
There is a gradient on the panel which just requires deletion not sure if its significant enough for github to detect the change in the file.
@cschol Did I do something wrong the makefile everything seems correct in the make my end.
new version 0.6.5 https://github.com/Coirt/Bark/tree/0.6.5
Do you want me to hook the build up to the 0.6.5
branch? Otherwise, you have to either create a tag for 0.6.5
or merge the 0.6.5
branch into master.
Sorry just saw... What is easier for you?
Not too sure what's going on could you take a look at the PR I made to see if there is actually conflicts, couldn't auto merge!
Generally it is not good to have branches and tags with the same name. They are ambiguous. 0.6.5
in this case.
I think you should get your version control straightened out first.
First, you have to delete the 0.6.5
tag:
git tag -d 0.6.5
Then you checkout the master
branch and merge the 0.6.5
into master
:
git checkout master
git merge 0.6.5
Now, you will encounter a conflict in changelog.txt
. Open the file in your preferred editor and resolve the conflict.
Then add the file and continue the merge:
git add changelog.txt
git merge --continue
It should finish the merge cleanly now. It did for me. Then push up master
to Github:
git push origin master
resolved "conflicts" they were just new lines (non wrapped)
Master now 0.6.5
@cschol I see what you mean there. Taken under advisement! Thanks for the info.
Updated build.
Master now v0.6.6
Updated build
Hi guys, master now v1.0.0
Should I just increment the version in the json and post the commit hash for future updates?
I have one incoming with a small bugfix it is not worth creating a new branch for it.
Yes, that will be perfect.
Right so cheers.
v1.0.1 commit 4b0fac8
Question will escape sequences show on the Plugin Library?
Just realised I filled in the wrong "name" field in the manifest. Plugin shows as Coirt, no need to update can get it next submit.
Wondering if this would be an acceptable feild for "name": "Coirt\t / \t Bark"
I made those changes to manifest "name": "Coirt\t/\tBark"
, I can change it and post another commit if it is not accepted, hoping it will turn out like Coirt / Bark
on the library page.
v1.0.2 commit 563f4a9
I mean weird spacing is bad typography
Some may say unique :laughing: I can change it if it looks too weird.
Doesn't show correctly in rack :roll_eyes:
New version with some bug fixes...
v1.0.3 commit 43b78a2
v1.0.4 commit: 574031a
Master now at v1.1.0 commit 7caca3c
Lots of files updated and new components
Would it be okay to submit a new build?
I got some criticism's about the new panels/components so I tweaked them.
Hurry up and I will get it in.
Sweet ready to go just going to merge!
commit d67e447 v1.1.1
Hope all is well!
New version: commit b00403f v1.2.0 https://github.com/Coirt/Bark/commit/b00403fa6d66e7f15dfbb839a505efad1fc0bbc4
New version available.
I hope I got the linker right in the makefile builds okay for me on windows though not sure about other platforms. Using a faster approximation of sin, for optimisations.
Master: v1.2.4 commit: 6b751c9df54d9917cd84ad3069a3bc30c33c3687
Build failure on Linux and Mac platforms: https://github.com/Coirt/Bark/issues/29
Thank you @cschol commit: 7ad510f36ac5c266a8df8fb1c6cf878f20d15532
https://github.com/Coirt/Bark/commit/7ad510f36ac5c266a8df8fb1c6cf878f20d15532
All good so? 🤞
All good as far as I can tell.
Great, thanks again for the help!
New version, bug fixes on Mac
commit: f9f6cab51dd1e290cf28d7bdc0932ecf466e722d
Suppose I'd better submit the new version.
Master at version v2.3.0 Commit: 64376ea01035343245498bc3934d25395af79d3b
Hi guys Looking to add my modules to the plugin manager
URL: https://github.com/Coirt/Bark License: BSD-4-Clause Minifest: https://github.com/Coirt/Bark/blob/0.6.3/Bark.json