search

VCVRack / library

Database for the VCV Library
https://library.vcvrack.com/
380 stars 82 forks source link

ODDSound_MTS_ESP #677

Closed olicash closed 2 years ago

olicash commented 3 years ago

Hi,

I would like to add our plugin to the VCV Library.

source code: https://github.com/ODDSound/MTS-ESP-VCVRack version: v1.0.0 branch: main commit hash: 0875389

AndrewBelt commented 3 years ago

This looks like a derivative work of VCV Core module panels, which is not allowed by the CC BY-NC-ND 4.0 license. https://github.com/VCVRack/Rack/blob/v1/LICENSE.md

olicash commented 3 years ago

Apologies, I hadn't seen that, me taking shortcuts! Have removed them from the SVGs, hope that's ok, let me know if not!

commit hash: 9ba1d63

AndrewBelt commented 3 years ago

This is still a derivative work. Closing. Reopen when all Core panel content is removed.

olicash commented 3 years ago

All that is in the SVGs now is a background layer, some text, four lines, and the backgrounds for the output ports. Can you point me to exactly what I need to remove and I'll get it done asap.

nay-seven commented 3 years ago

As far that i know, you need to create your own design, with your fonts and presentation, yours are copy of VCV core

olicash commented 3 years ago

The presentation is necessarily the same. We want the panel layout to be the same because the devices here are intended to leverage users familiarity with these core devices i.e. be the same but just with microtuning support added.

The SVGs are no longer adaptations of the original panels. They copy the layout sure, but I have now pieced them together by hand, with a different font. Perhaps it's the use of the MIDI Widget that is the issue?

If I could know exactly what is acceptable to be able to add this functionality to the core devices then I can go about fixing it.

olicash commented 3 years ago

Hi,

Hopefully panels ok now?

Thanks, Oli.

source code: https://github.com/ODDSound/MTS-ESP-VCVRack version: v1.0.0 branch: main commit hash: eda6117

cschol commented 3 years ago

Build failure on Windows platform: https://github.com/ODDSound/MTS-ESP-VCVRack/issues/1

cschol commented 3 years ago

Your plugin has been integrated and will be available for all supported platforms with the next Plugin Manager update. Please let us know in this issue when a new version is available. We will reopen it. Thank you for providing your plugin to the Rack community.

AndrewBelt commented 3 years ago

The panel is still clearly a derivative work, but I have recently purchased the rights to VCV Rack's graphics. I would really appreciate it if you designed your own panel, but I will allow this particular panel to be released. In a future version I would encourage you to redesign it.

olicash commented 3 years ago

Update for ODDSound MTS-ESP plugin:

Version: 1.0.1 Commit: 40caa52f2c801dd3712bb77005d70ee358ae6e3e Updates: New Quantizer and Interval modules.

Thanks! Oli

olicash commented 2 years ago

Update for ODDSound MTS-ESP plugin, ready for Rack 2:

Version: 2.0.1 Commit: 1d056c63db667326b977f1d0a69cd86519a0e654

Thanks! Oli

olicash commented 2 years ago

Update for ODDSound MTS-ESP plugin:

Version: 2.0.2 Commit: 7d1aaef1234df51278c9147802d4d84952431073 Updates: Fixes for CV To MIDI and MIDI To CV modules.

Thanks! Oli