search

VCVRack / library

Database for the VCV Library
https://library.vcvrack.com/
374 stars 81 forks source link

SunsetSignals #685

Closed a51bot closed 2 years ago

a51bot commented 2 years ago

https://gitlab.com/jeremy_mitchell/sunsetsignals

Hi, This is my first plugin for vcv-rack and I read and tried to follow the publishing guide, so just let me know if there is anything else I need todo to have this plugin (SignalBooster) published.

Thanks! Jeremy

a51bot commented 2 years ago

35cee6e7576175802fd07c948fdbc3f22615fe71 - version 1.0.0

cschol commented 2 years ago

Invalid tags in plugin.json:

sunsetsignals] Validating plugin.json...FAILED    
[sunsetsignals] Issues found in `plugin.json`:                                                                                                                                                                                                                                                                        

SignalBooster: invalid module tags: booster, db, signal-booster                                                                                                                                                                                                                                                       
-- Valid tags are defined in https://raw.githubusercontent.com/VCVRack/Rack/v1/src/tag.cpp
a51bot commented 2 years ago

Ah thanks, I updated the plugins.json with the Utility tag. 2f3a99155f3832464c17106e75c605a910608680

cschol commented 2 years ago

Looks good. One recommendation: with your next update, add an explicit copy of the license to the repository in a file called LICENSE, rather than just linking to the external license text. That way, the license file can also be included in the plugin distribution.

cschol commented 2 years ago

Your plugin has been integrated and will be available with the next Plugin Manager update for all supported platforms. Please let us know in this issue when a new version is available. We will reopen it. Thank you for providing your plugin to the Rack community.