search

VCVRack / library

Database for the VCV Library
https://library.vcvrack.com/
385 stars 82 forks source link

Mojo #687

Open tomdasilva opened 3 years ago

tomdasilva commented 3 years ago

https://github.com/tomdasilva/Mojo

Hi ! I hope those three modules will be ok for getting into the VCV Library :) Best Regards Tom

cschol commented 3 years ago

Build artifacts committed to the repository: https://github.com/tomdasilva/Mojo/issues/1 Invalid characters in plugin.json: https://github.com/tomdasilva/Mojo/issues/2

tomdasilva commented 3 years ago

Hi ! invalid characters have been modified in the plugin.json file :)

cschol commented 3 years ago

Thanks. Build artifacts are still an issue though.

tomdasilva commented 3 years ago

Hi ! I hope everything is fine now ... thanks !

cschol commented 3 years ago

@tomdasilva dist directory and plugin.dll need to be removed also with the same methodology. All of these artifacts will be rebuilt during the build process. Thanks.

tomdasilva commented 3 years ago

Ok ! Is it fine now ? Thanks a lot :)

cschol commented 3 years ago

One more thing: sourceURL in the plugin.json still contains weird characters. Everything else looks good.

tomdasilva commented 3 years ago

So many issues ;) i corrected it !

cschol commented 3 years ago

Your plugin has been integrated and will be available for all supported platforms with the next Plugin Manager update. Please let us know in this issue when a new version is available. We will reopen it. Thank you for providing your plugin to the Rack community.

tomdasilva commented 3 years ago

So great ! thanks lot !

tomdasilva commented 3 years ago

Hi ! I updated my plugin.json file for the migration from v1 to v2 :) Thnaks to have a look at it, i hope everything will be ok !

Have a good day

https://github.com/tomdasilva/Mojo

cschol commented 3 years ago

Great job! Your plugin passed all integration tests and builds successfully against the current SDK git.219bbaf1 for all supported platforms using the new v2 toolchain.

However, we are not accepting submissions to the library for v2 of Rack yet. We will let developers know when to submit their v2 plugins to the library. Thank you.

cschol commented 2 years ago

Update requested for v2.

tomdasilva commented 5 months ago

Hi ! I made some major updates to my Plugin with three new modules. I wish to push them to the VCV library :) Thanks to have a look at it ! Have good day

New version: v3.0 (https://github.com/tomdasilva/Mojo - updates were pushed to main branch)

cschol commented 5 months ago

Manifest issues: https://github.com/tomdasilva/Mojo/issues/5

AndrewBelt commented 4 months ago

Looks like @tomdasilva fixed this.

cschol commented 4 months ago

Latest plugin revision crashes Rack when module browser loads. This is on GNU/Linux. @tomdasilva