monome - Githubissues

Dewb commented 1 year ago

URL: https://github.com/Dewb/monome-rack

Version: 2.1.0 Commit: e3b515fb039e5ed3834a4344a1a759273ab3e0e3

This has been a long time coming!

cschol commented 1 year ago

Build issue: https://github.com/Dewb/monome-rack/issues/158

Dewb commented 1 year ago

Version 2.1.1 Commit: 41bb4b349b16abd6f11e1d439c7ba7ebd698e879

Dewb commented 1 year ago

Version 2.1.2 Commit: 6f3ee23f8adfd0dc93450f585078189e7c2a5690

cschol commented 1 year ago

Your plugin has been integrated and will be available for all supported platforms with the next Plugin Manager update. Please let us know in this issue when a new version is available. We will reopen it. Thank you for providing your plugin to the Rack community.

AndrewBelt commented 12 months ago

I built this, but it has a few bugs that create issues with Rack, so I'd rather not release it before they are fixed.

Without instantiating any modules from this plugin, Rack prints "Binding to port 13000." to the terminal. Plugins shouldn't initialize things like this without first instantiating a module. Consider lazy initialization when a module requires it, rather than when the plugin is loaded. This looks to be the culprit: https://github.com/Dewb/monome-rack/blob/main/src/plugin.cpp#L51-L57
The modules grid64, grid128, and grid256 override key commands such as Delete/Backspace to delete and Ctrl-E to bypass. Modules shouldn't override these keys since users should assume that they work with all modules. I don't see a valid reason that these modules should override them.

Dewb commented 12 months ago

Agreed, lazy init was already implemented for that subsystem, looks like I stuck a temporary line of code to force loading in plugin init a while back and forgot to take it out.
This is indeed a bug, looks like I forgot to call the parent handler when overriding ctrl-click handling, inadvertently breaking all standard shortcuts.

Should be pretty quick to fix these, thanks!

Dewb commented 12 months ago

Version: 2.1.3 Commit: 1bb0b6460ad76fd2402cdc34bf4b61864feb95ab

AndrewBelt commented 11 months ago

I found another high-priority bug that should be fixed in the plugin's next version.

When launching the module browser, the terminal says Binding to port 13000. Your plugin should NOT initialize when only a ModuleWidget is created, but when a Module is created.

Dewb commented 10 months ago

Version: 2.1.4 Commit: 435b94022a36702e3199512fcde0584bdc47c709

Changelog:

Update to Rack SDK 2.4.0
Make sure firmware binaries are cleaned from res/ in between platform builds
Move serialosc lazy initialization out of ModuleWidget into Module constructor

Dewb commented 10 months ago

Version: 2.1.5 Commit: 2147c80d246de8161c7f945d36ce9beb3bd16083

Changelog:

Support new dark panel preference

Dewb commented 9 months ago

Version: 2.2.0 Commit: b478dbe2b84401c4d384e76a28c89ff6aa38df9c

Changelog highlights: alt-firmware support, teletype 5.0beta4 firmware added, grid mirror mode, new module “faderbank”, new preset “MINIM”, bug fix to Unicode path handling, details

Dewb commented 8 months ago

Version: 2.2.1 Commit: b5c77664dc5834ee29b2909dd71b2fab640f168c

Changelog: fix user-reported crash

Dewb commented 8 months ago

Version: 2.2.2 Commit: 562c323ccacbb757f57aed81da3b06dd5ff90d9c

Changelog: faderbank voltage range option, polyphonic option, UI tweaks

Dewb commented 8 months ago

Version: 2.2.3 Commit: 48d8ebf05ead58b1dab337c13b2935343fea134c

Changelog (details)

Teletype international/custom keyboard layout support
Faderbank bug fixes: fix 1 pixel panel gap, initialize voltage ranges correctly.

Dewb commented 5 months ago

Version: 2.2.5 Commit: 4ee3221ace4bea0e8ee2ad92fa4095a41adba244

Changelog (details):

Teletype 5.0 is out of beta; update firmware to released version and make 5.0 the default (existing patches remain on 4.0)
Ansible CV outputs should go all the way to zero

Dewb commented 5 months ago

Version: 2.2.6 Commit: 73be53db80a0ba061ac344629bda2aa1129c8c7d

Thanks for the quick turnaround! I unfortunately have a question/issue about the library build process stemming from the 2.2.5 update.

Details

The library build of 2.2.5 reports the correct commit hash for Teletype 5.0, but the tag-derived version number is still 4.0.

Some possible hypotheses for what is happening here: 1. The library build process might not be doing a clean before each build, which would be a completely fair thing to do. 2.2.6 should fix this case. But the commit hash was correctly updated, meaning the build step did run, therefore this is probably not sufficient to fix it. 2. The library build process might be intentionally not fetching the full tag history, either by doing a shallow clone or providing `--no-tags`. If this were the case, then the 4.0.0 tag probably would have never worked, so I think this can be ruled out. 3. The library build process might need to run `git submodule sync` before `git submodule update` in case the plugin repo contains submodules and the contents of `.gitmodules` has changed. The contents of `.gitmodules` did change in 2.2.5 to point the teletype5 module url to the upstream repo. And the old url did not contain the v5.0.0 tag, so the output is consistent with this hypothesis. But I see in `update.py` that `git submodule sync` *is* being called; so if that's the version of the script being used, that should rule out this hypothesis also. I've added the v5.0.0 tag to the old repo so maybe the problem will go away with 2.2.6, but it would be good to get to the bottom of this as I do plan to make more changes to the .gitmodules configuration.

Dewb commented 5 months ago

Aha, ignore all my blather above, I think this is the issue: https://github.com/VCVRack/library/pull/785

cschol commented 5 months ago

Build failure with 2.2.6: https://github.com/Dewb/monome-rack/issues/193

Dewb commented 5 months ago

Version: 2.2.7 Commit: 16827b0d3fe8c8d291d903dc6d84102718007e9a

VCVRack / library

monome #768