VCVRack / library

Database for the VCV Library
https://library.vcvrack.com/
385 stars 82 forks source link

Rigatoni #775

Closed ianjhoffman closed 1 year ago

ianjhoffman commented 1 year ago

Just finished my first VCV Rack module - it's a small waveshaper/utility module that emulates TZFM, based on this ModWiggler topic.

GitHub repo: https://github.com/ianjhoffman/RigatoniModular

AndrewBelt commented 1 year ago

Your plugin slug is named after 1 module in the plugin. What if you add more modules to the plugin? Would it make more sense to name the plugin "Rigatoni" with the slug Rigatoni?

ianjhoffman commented 1 year ago

@AndrewBelt is it generally best to have all modules from a virtual "manufacturer" in one repo<->plugin?

ianjhoffman commented 1 year ago

Updated the issue title, repo name, and manifest to better reflect your suggestion!

AndrewBelt commented 1 year ago

Usually, yes. If you had 20 plugins instead of 20 modules in 1 plugin, it'd be a nightmare to push/build/test/update them all. Thanks, the next step is to wait on our review and build!

cschol commented 1 year ago

Plugin fails to load: https://github.com/ianjhoffman/RigatoniModular/issues/1

ianjhoffman commented 1 year ago

Should be working now!

cschol commented 1 year ago

New issue logged in https://github.com/ianjhoffman/RigatoniModular/issues/1. Panel fails to load.

ianjhoffman commented 1 year ago

Thanks for keeping up with these - that should be resolved too :)

cschol commented 1 year ago

Your plugin has been integrated and will be available for all supported platforms with the next Plugin Manager update. Please let us know in this issue when a new version is available. We will reopen it. Thank you for providing your plugin to the Rack community.

ianjhoffman commented 1 year ago

Hi! New version of Rigatoni is available with an additive voice, Loom. V2.2.0

cschol commented 1 year ago

Compile failure on macOS platform: https://github.com/ianjhoffman/RigatoniModular/issues/6

ianjhoffman commented 1 year ago

Confirmed recent changes cause the plugin to build on all 4 target platforms using https://github.com/VCVRack/rack-plugin-toolchain