search

VCVRack / library

Database for the VCV Library
https://library.vcvrack.com/
380 stars 82 forks source link

FrequencyDomain #803

Open almostEric opened 3 months ago

almostEric commented 3 months ago

latestVersion : 2.0.1 commit hash: 4d4cec4511d72fcdf1799a237044aaa2fc2d715e branch: Master

AndrewBelt commented 3 months ago

What repo URL?

almostEric commented 3 months ago

Sorry about that.

https://github.com/almostEric/Frequency-Domain.git

Eric Sterling | CTO DigitalPour | 503.724.6536

https://zoho.email-view.com/click.zt?linkDgs=312b686309b19&mailDgs=312b686309b16 www.digitalpour.com | https://zoho.email-view.com/click.zt?linkDgs=312b686309b1a&mailDgs=312b686309b16 @DigitalPour | https://zoho.email-view.com/click.zt?linkDgs=312b686309b18&mailDgs=312b686309b16 Facebook

From: Andrew Belt @.> Sent: Monday, June 10, 2024 7:10 AM To: VCVRack/library @.> Cc: Eric Sterling @.>; Author @.> Subject: Re: [VCVRack/library] FrequencyDomain (Issue #803)

What repo URL?

— Reply to this email directly, view it on GitHub https://github.com/VCVRack/library/issues/803#issuecomment-2157280956 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AADPVT7R7DJYPKR3TJGV423ZGUYK5AVCNFSM6AAAAABJBAEWYSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJXGI4DAOJVGY . You are receiving this because you authored the thread. https://github.com/notifications/beacon/AADPVT2ZVWLGZZUIKT3RSH3ZGUYK5A5CNFSM6AAAAABJBAEWYSWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUASV7LY.gif Message ID: @. @.> >

fractalgee commented 3 months ago

@cschol

cschol commented 3 months ago

Compile failure: https://github.com/almostEric/Frequency-Domain/issues/1

almostEric commented 3 months ago

latestVersion: 2.0.1 commitHash: 3a1abb8dd7c44344ba66bc1609f6dcf62ddcba3e branch: master

almostEric commented 3 months ago

Not sure how I am supposed to fix this compile error? I am building against 2.5.2 successfully, and the "missing" dlls are part of vcv?

almostEric commented 3 months ago

latestVersion: 2.0.1 commitHash: 89db78a27d364d88f76953ab41e80d9eef53a5b6 branch: master

almostEric commented 3 months ago

turns out those includes were not being used, so...

cschol commented 3 months ago

Updated issue above with patch that fixes build.

Also: https://github.com/almostEric/Frequency-Domain/issues/2

almostEric commented 3 months ago

latestVersion: 2.0.1 commitHash: 37c320fb898afc835b6e25ca68c796cc3ad6c92d branch: master

I fixed that other file and used bfg repo-cleaner. it says it removed the plugin.dll but I'm still seeing it. Let me know this commit works

cschol commented 3 months ago

Thanks. Build completes successfully. plugin.dll file is still present in the repo in this revision. Not sure what happened with BFG Cleaner.

almostEric commented 1 month ago

So is plugin.dll being present (even though removed from repo) preventing frequency domain being updated in library?Why does vcv suck so bad at communicating these days 😕Sent from my iPhoneOn 30 Jun 2024, at 16:15, cschol @.***> wrote: Thanks. Build completes successfully. plugin.dll file is still present in the repo in this revision. Not sure what happened with BFG Cleaner.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

cschol commented 1 month ago

SHA 37c320fb898afc835b6e25ca68c796cc3ad6c92d doesn't exist in the repo.

plugin.dll is still present:

image

Watch your communication style.