VCVRack / rack-plugin-toolchain

56 stars 13 forks source link

Failing to copy the build plugin to directory "plugin-build" #15

Closed modlfo closed 2 years ago

modlfo commented 2 years ago

I'm having a problem in the last step of building a plugin. This is the error I get

cp /home/build/plugin-src/dist/*.vcvplugin plugin-build/
cp: cannot create regular file 'plugin-build/Geodesics-Vultiverse-2.0.0-win.vcvplugin': Permission denied

I have tried a few things, like changing the permissions of the directory and manually creating it before invoking the build.

Any idea on how to solve this?

I'm running docker on an Ubuntu 21.04.

modlfo commented 2 years ago

I just figured it out.

When passing the argument.

--volume=$(PWD)/$(PLUGIN_BUILD_DIR):/home/build/rack-plugin-toolchain/$(PLUGIN_BUILD_DIR)

The $(PWD) returns an empty string for me. So it is not mapping the correct volume.

cschol commented 2 years ago

OK. That's strange. Are you using bash?

modlfo commented 2 years ago

Yes. If I run $ echo $PWD I get the expected result. I'm not sure why when running make the variable has no value. Could it be related to me having to run docker with sudo?: make -j8 docker-plugin-build PLUGIN_DIR=...

cschol commented 2 years ago

Yes. You should not have to run Docker with sudo. Check the Docker documentation to allow the current user to run Docker without needing sudo.

Reference: https://docs.docker.com/engine/install/linux-postinstall/

modlfo commented 2 years ago

Thanks! it's working now.