search

VDBWRAIR / biotest

Testing framework to make python unittesting easier
GNU General Public License v2.0
1 stars 0 forks source link

added interleave strategy #4

Closed necrolyte2 closed 8 years ago

necrolyte2 commented 8 years ago

I assume the way I'm ensuring duplicate id's is wrong, but it was the only way I could get it to work https://travis-ci.org/VDBWRAIR/biotest/jobs/109926611#L474

Thoughts? @averagehat

averagehat commented 8 years ago

I can't recreate the problem locally. Can you?

averagehat commented 8 years ago

I can get a warning on my home PC (but not a failure). I wonder if this is a computing speed problem in Travis. I think we can make it faster. I'll ask on IRC if I can't figure it out.

necrolyte2 commented 8 years ago

Sorry for the late response. Ya, I don't get the error on my machine. I suspect you are correct about the speed.

I would hate to have it ignore the warning, but I'm wondering if the issue is just simply because I'm not correctly building the strategy.

averagehat commented 8 years ago

Performance info: http://www.drmaciver.com/2015/07/notes-on-hypothesis-performance-tuning/ BTW hypothesis doesn't support 2.6 anymore edit: another blogpost: http://www.drmaciver.com/2015/08/how-to-generate-a-list-plus-an-element-of-it/

averagehat commented 8 years ago

I fixed the speed problem but it's failing because of 2.6 support.

averagehat commented 8 years ago

FYI, I think the reason the code was slow before, is because

  1. the st.text() had no upper bound and
  2. the st.text() strategy was being fed into a second st.textas the alphabet. [maybe? not sure]
  3. the second st.text also had no upper bound in size.
averagehat commented 8 years ago

I fixed the build in #5. So I will merge that instead.