Tizio-Spig/automatically return to body in noclip

VDP-noclip / noclip

NOCLIP is an experimental game in which you “noclip” the environment to solve puzzles.

3 stars 1 forks source link

Tizio-Spig/automatically return to body in noclip #138

Closed TizioMaurizio closed 1 year ago

TizioMaurizio commented 1 year ago

Changes

need to press&hold the noclip key to stay in noclip
automatically go back to your body when releasing the key
allow to set the noclip hints in the editor

Fixes

fix noclip camera animation rotation lerp
fix camera position when switching to noclip
fix fadein bug if you activate noclip during fade in

TizioMaurizio commented 1 year ago

I suggest taking a look to the Untampered() (tampered means manomesso) method in mouselook and fadein2, the same solution solved two different problems and can possibly simplify other future fixes, it basically prevents the script from working if the state it is trying to modify is not consistent with what the script was working on in the frame before (which means we want to give precedence to external modifications)

spig95 commented 1 year ago

In my opinion, this is now ready to be merged and everything work. Automatically returning back to the body is a really cool feature!

I think that, as also @TizioMaurizio mentioned, mouseLook can be improved. However, this is not straightforward. I opened an issue and we can work on it after the demo, as this is not urgent at all.