search

VDP-noclip / noclip

NOCLIP is an experimental game in which you “noclip” the environment to solve puzzles.
3 stars 1 forks source link

Change hierarchy of allPlayer prefab #44

Closed stefanofossati closed 1 year ago

stefanofossati commented 1 year ago

AllPlayer     ├RealityPlayer     │    ├RealityBody     │    └RealityCamera     └NoclipPlayer            └NoclipCamera

stefanofossati commented 1 year ago

There is another bug: the noclip camera has the same reality player position. So the function OnTriggerEnter of the noclip collider creates problem when there is a switch camera from reality mode to noclip. This problem happens after the first switch camera

bottolo commented 1 year ago

There seem to be a few conflicts with some files. Can you manage to resolve them? Once done, I'll have a look at the build! Nice labels by the way.

stefanofossati commented 1 year ago

Before merging, I try to fix the bugs

stefanofossati commented 1 year ago

I have resolved the merge conflict, but the orientation bug isn't resolved. Probably the update of mouseLook overwrite the changes of the rotation. Maybe the mouseLook isn't implemented well

stefanofossati commented 1 year ago

the problem on the colliders is now solved

spig95 commented 1 year ago

There is another bug: the noclip camera has the same reality player position. So the function OnTriggerEnter of the noclip collider creates problem when there is a switch camera from reality mode to noclip. This problem happens after the first switch camera

I am not sure, but it might be that we both worked on a similar topic and merging this PR created conflicts. I am going to see if I can fix the conflicts, else we can update each other

stefanofossati commented 1 year ago

There is another bug: the noclip camera has the same reality player position. So the function OnTriggerEnter of the noclip collider creates problem when there is a switch camera from reality mode to noclip. This problem happens after the first switch camera

I am not sure, but it might be that we both worked on a similar topic and merging this PR created conflicts. I am going to see if I can fix the conflicts, else we can update each other

I have solved the conflicts, for me the implementation works fine, @spig95 check and if it's fine we can finnally merging

stefanofossati commented 1 year ago

I have left some comments in the code.

Moreover, I have noticed that if I am in the noclip mode and I look into a direction, if I press W the camera does not move in that direction, but instead it moves horizontally. In develop, the behavior is different. Is this wanted or not?

Ok I have found the issue. Now all should works, the problem is that I don't like the noclip player that is empty. But we can change the structure later.