VDVde / OJP

Open API for distributed journey planning. CEN/TS 17118:2017.
https://www.vdv.de/open-journey-planner.aspx
22 stars 12 forks source link

Solve merge conflicts on generated documentation in each branch #288

Closed sgrossberndt closed 4 months ago

sgrossberndt commented 1 year ago

The current situation is not good regarding the process to get a change merge ready. Each pull request / branch has to be checked out and changes_for_v1.1 has to be merged into it and requires another run of the ci job updating the generated documentation.

The reason the generated documentation is there in each branch / pull request is for people to be able to see the outcome of their XSD changes in the generated documentation.

I would like to propose a different concept here:

e.g.:

What do you think about this?

herlitze commented 1 year ago

Sounds reasonable to me.

ue71603 commented 1 year ago

Is also ok for me. Perhaps not having folders, but instead of index.html we use the .html. But you may do as you please. Will you use .ignore for the generated folder? @skinkie your view?

sgrossberndt commented 1 year ago

If we would put them into the same folder, they would all share the asciidoc.css file. If we change anything in that file, it wouldbe changed for all files. Therefore I think having folders is a better option.

ue71603 commented 1 year ago

Hi Stephan. Fine with me.

sgrossberndt commented 1 year ago

Sigh. Well. It works, but it doesn't. I am now able to deploy the generated index.html of a branch to subdirectory, but uploading this will replace the whole github-pages deployment. So the newly generated index.html in a subfolder is there but the former branches and the main index.html of the changes_for_v1.1-branch are gone then :-(

sgrossberndt commented 1 year ago

Another option would be to generate the index.html of each existing branch with every run. This may be some overhead, but it would work..