search

VDVde / OJP

Open API for distributed journey planning. CEN/TS 17118:2017.
https://www.vdv.de/open-journey-planner.aspx
22 stars 12 forks source link

Aligning MultiPointTripPolicyGroup with TripPolicyGroup #333

Closed trurlurl closed 1 year ago

trurlurl commented 1 year ago

Shouldn't the recent additions to the TripParams also be available to MultiPointTripRequest?

OptimisationMethods, ItModesToCover, ConsiderElevationData

ue71603 commented 1 year ago

@trurlurl Can you do all the changes according to Stephan or should I do it? And yes: They should be harmonized fully.

sgrossberndt commented 1 year ago

Working on it.

sgrossberndt commented 1 year ago

ItModesToCover has the definition:

For each mode in this list a separate monomodal trip shall be found - in addition to inter-modal solutions.

Does this make sense for a MultiPointTripPolicyGroup for you? I'd rather not add it there, I think it is on purpose this was only part of TripPolicyGroup and not MultiPointTripPolicyGroup.

trurlurl commented 1 year ago

ItModesToCover has the definition:

For each mode in this list a separate monomodal trip shall be found - in addition to inter-modal solutions.

Does this make sense for a MultiPointTripPolicyGroup for you? I'd rather not add it there, I think it is on purpose this was only part of TripPolicyGroup and not MultiPointTripPolicyGroup.

I could imagine that it could make sense when distributing a search for monomodal trips by calling OJPMultiPointTripRequest for parts of the trip - and that these parts should also be monomodal.

ue71603 commented 1 year ago

@sgrossberndt I think you are right about ItModesToCover. That shouldn't be done in MPTR

ue71603 commented 1 year ago

I think we can define MPTR that it is used in the middle of distributed trip planning and I think if one ones monomdal trips through Europe, one does this directly on one iv trip planner.