search

VDVde / OJP

Open API for distributed journey planning. CEN/TS 17118:2017.
https://www.vdv.de/open-journey-planner.aspx
22 stars 12 forks source link

ITModesToCover -> ModesToCover #342

Closed ue71603 closed 1 year ago

ue71603 commented 1 year ago

also change in behaviour. This would help in having a special mode within. E.g. especially "air" and "ferry", boat

skinkie commented 1 year ago

Is there a reason not to use this one from upstream?

ue71603 commented 1 year ago

What do you mean with "this" one of the zillion mode enumerations? Because they don't fit fully. And you know how the MODE discussions is starting to unbound itself from any boundaries.... But I am open to suggestions.

skinkie commented 1 year ago

My fundamental problem is here that we start a new enumeration that will absolutely require mapping in the serving application. Rather than passing forward the value of the upstream enumeration.

ue71603 commented 1 year ago

I agree, but can of worms..... Do you try to do the PR?

skinkie commented 1 year ago

Functional requirement first: which modes are we missing?

ue71603 commented 1 year ago

We will not do that. Added a new section 5.4.2 telling, that it is the enquirer's work.