VDVde / OJP

Open API for distributed journey planning. CEN/TS 17118:2017.
https://www.vdv.de/open-journey-planner.aspx
22 stars 12 forks source link

Change main namespace of OJP from SIRI to OJP #347

Closed ue71603 closed 1 year ago

ue71603 commented 1 year ago

https://github.com/VDVde/OJP/pull/339/files but not in a different repository.

ue71603 commented 1 year ago

@Aurige doesn't compile in OJP.xsd. Pls check why this is...

ue71603 commented 1 year ago

We are back at the QName problem (which blocked the change last time, as far as I know): siri/xsd/siri_model/siri_situationIdentity.xsd:145: element element: Schemas parser error : element decl. '{http://www.siri.org.uk/siri}CountryRef', attribute 'type': The QName value '{http://www.ifopt.org.uk/ifopt}CountryRefStructure' does not resolve to a(n) type definition. siri/xsd/siri_model/siri_situationIdentity.xsd:167: element element: Schemas parser error : element decl. '{http://www.siri.org.uk/siri}UpdateCountryRef', attribute 'type': The QName value '{http://www.ifopt.org.uk/ifopt}CountryRefStructure' does not resolve to a(n) type definition. siri/xsd/siri_model/siri_situationIdentity.xsd:208: element element: Schemas parser error : element decl. '{http://www.siri.org.uk/siri}VersionCountryRef', attribute 'type': The QName value '{http://www.ifopt.org.uk/ifopt}CountryRefStructure' does not resolve to a(n) type definition. siri/xsd/siri_model/siri_facility.xsd:197: element element: Schemas parser error : element decl. '{http://www.siri.org.uk/siri}StopPlaceRef', attribute 'type': The QName value '{http://www.ifopt.org.uk/ifopt}StopPlaceRefStructure' does not resolve to a(n) type definition. siri/xsd/siri_model/siri_facility.xsd:202: element element: Schemas parser error : element decl. '{http://www.siri.org.uk/siri}StopPlaceComponentId', attribute 'type': The QName value '{http://www.ifopt.org.uk/ifopt}StopPlaceComponentRefStructure' does not resolve to a(n) type definition. siri/xsd/siri_model/siri_facility.xsd:640: element element: Schemas parser error : element decl. '{http://www.siri.org.uk/siri}EquipmentRef', attribute 'type': The QName value '{http://www.ifopt.org.uk/ifopt}EquipmentRefStructure' does not resolve to a(n) type definition. siri/xsd/siri_model/siri_facility.xsd:650: element element: Schemas parser error : element decl. '{http://www.siri.org.uk/siri}EquipmentTypeRef', attribute 'type': The QName value '{http://www.ifopt.org.uk/ifopt}EquipmentTypeRefStructure' does not resolve to a(n) type definition. siri/xsd/siri_model/siri_facility.xsd:660: element element: Schemas parser error : element decl. '{http://www.siri.org.uk/siri}EquipmentStatus', attribute 'type': The QName value '{http://www.ifopt.org.uk/ifopt}EquipmentStatusEnumeration' does not resolve to a(n) type definition. siri/xsd/siri_model/siri_situationAffects.xsd:149: element element: Schemas parser error : element decl. '{http://www.siri.org.uk/siri}StopPlaceRef', attribute 'type': The QName value '{http://www.ifopt.org.uk/ifopt}StopPlaceRefStructure' does not resolve to a(n) type definition. siri/xsd/siri_model/siri_situationAffects.xsd:351: element element: Schemas parser error : element decl. '{http://www.siri.org.uk/siri}AccessMode', attribute 'type': The QName value '{http://www.ifopt.org.uk/ifopt}AccessModesEnumeration' does not resolve to a(n) type definition. siri/xsd/siri_model/siri_situationAffects.xsd:506: element element: Schemas parser error : element decl. '{http://www.siri.org.uk/siri}LinkProjection', attribute 'type': The QName value '{http://www.ifopt.org.uk/ifopt}LinkProjectionStructure' does not resolve to a(n) type definition. siri/xsd/siri_model/siri_situationAffects.xsd:684: element element: Schemas parser error : element decl. '{http://www.siri.org.uk/siri}FirstStopPlaceRef', attribute 'type': The QName value '{http://www.ifopt.org.uk/ifopt}StopPlaceRefStructure' does not resolve to a(n) type definition. siri/xsd/siri_model/siri_situationAffects.xsd:701: element element: Schemas parser error : element decl. '{http://www.siri.org.uk/siri}IntermediateStopPlaceRef', attribute 'type': The QName value '{http://www.ifopt.org.uk/ifopt}StopPlaceRefStructure' does not resolve to a(n) type definition. siri/xsd/siri_model/siri_situationAffects.xsd:718: element element: Schemas parser error : element decl. '{http://www.siri.org.uk/siri}LastStopPlaceRef', attribute 'type': The QName value '{http://www.ifopt.org.uk/ifopt}StopPlaceRefStructure' does not resolve to a(n) type definition. siri/xsd/siri_model/siri_situationAffects.xsd:788: element element: Schemas parser error : element decl. '{http://www.siri.org.uk/siri}LinkProjectionToNextStopPoint', attribute 'type': The QName value '{http://www.ifopt.org.uk/ifopt}LinkProjectionStructure' does not resolve to a(n) type definition. siri/xsd/siri_model/siri_situationAffects.xsd:1187: element element: Schemas parser error : element decl. '{http://www.siri.org.uk/siri}StopPlaceRef', attribute 'type': The QName value '{http://www.ifopt.org.uk/ifopt}StopPlaceRefStructure' does not resolve to a(n) type definition. siri/xsd/siri_model/siri_situationAffects.xsd:1236: element element: Schemas parser error : element decl. '{http://www.siri.org.uk/siri}NavigationPathRef', attribute 'type': The QName value '{http://www.ifopt.org.uk/ifopt}NavigationPathRefStructure' does not resolve to a(n) type definition. siri/xsd/siri_model/siri_situationAffects.xsd:1277: element group: Schemas parser error : Element '{http://www.w3.org/[20](https://github.com/VDVde/OJP/actions/runs/4608807304/jobs/8145079924#step:6:21)01/XMLSchema}group', attribute 'ref': The QName value '{http://www.ifopt.org.uk/ifopt}PlaceProjectionGroup' does not resolve to a(n) model group definition. siri/xsd/siri_model/siri_situationAffects.xsd:1262: element element: Schemas parser error : element decl. '{http://www.siri.org.uk/siri}ComponentRef', attribute 'type': The QName value '{http://www.ifopt.org.uk/ifopt}StopPlaceComponentRefStructure' does not resolve to a(n) type definition. siri/xsd/siri_model/siri_situationAffects.xsd:1272: element element: Schemas parser error : element decl. '{http://www.siri.org.uk/siri}ComponentType', attribute 'type': The QName value '{http://www.ifopt.org.uk/ifopt}StopPlaceComponentTypeEnumeration' does not resolve to a(n) type definition. siri/xsd/siri_model/siri_situation.xsd:503: element element: Schemas parser error : element decl. '{http://www.siri.org.uk/siri}Country', attribute 'type': The QName value '{http://www.ifopt.org.uk/ifopt}CountryRefStructure' does not resolve to a(n) type definition. WXS schema OJP.xsd failed to compile

Aurige commented 1 year ago

@Aurige doesn't compile in OJP.xsd. Pls check why this is...

It looks Ok on my side ... what should I check ? I did a global validation in XML Spy (all xsd, all examples) and everything is OK !

ue71603 commented 1 year ago

@Aurige CI says no: https://github.com/VDVde/OJP/actions/runs/4608807304

ue71603 commented 1 year ago

It works, but I had to fix SIRI. Created an issue, because doing a PR would break a lot of things there: https://github.com/VDVde/OJP/pull/347/commits/1d7a3ea047d95ad16287643d378a2081f7837530

https://github.com/SIRI-CEN/SIRI/issues/107

I suggest we work with it and do the PR in SIRI, if necessary.

ue71603 commented 1 year ago

added to SIRI https://github.com/SIRI-CEN/SIRI/pull/108

herlitze commented 1 year ago

We did change the default namespace of TRIAS once, and got complaints because some clients were expecting them in a specific way and could not handle any other way. But a change with version 2.0 should be fine.