VDVde / OJP

Open API for distributed journey planning. CEN/TS 17118:2017.
https://www.vdv.de/open-journey-planner.aspx
22 stars 12 forks source link

added TripChangeRequest #357

Closed herlitze closed 1 year ago

herlitze commented 1 year ago

Added parts of TripChangeRequest as planned in issue #352 .

added:

Functionality: Add WaitingTime at transfer (timed leg end/ timed leg start)

Parameter: Single Trip to change (given by TR before) TripLegRef Flag for earlier departure or later arrival (only with StopPointRef) TripRequestOptions (same structure as in TR)

not added yet:

Functionality: Add sharing operator to an estimated trip

Parameter: TripLegRef from and to or StopPointRef Selected Operator

For the documentation: It is important to mention that sharing may change the whole trip structure (e.g. walk - bus - transfer - train may result in walk - sharing - transfer train)

ue71603 commented 1 year ago

examples missing. Will write some.

trurlurl commented 1 year ago

Is there a reason not to have an ErrorCondition? To indicate that no alternative trip has be found, that ChangeLegRef does not refer to a valid TransferLeg, ..?

I don't remember the oral discussion in all detail - don't have the initial search parameters have to be known since part of the trip has to be recalculated?

ue71603 commented 1 year ago

Is there a reason not to have an ErrorCondition? To indicate that no alternative trip has be found, that ChangeLegRef does not refer to a valid TransferLeg, ..?

I don't remember the oral discussion in all detail - don't have the initial search parameters have to be known since part of the trip has to be recalculated?

We should add one as well

ue71603 commented 1 year ago

Malte: Will do the second part. New functionality is only moving it from the TripInfoRequest.

ue71603 commented 1 year ago

@herlitze something very bad happened in this commit: https://github.com/VDVde/OJP/pull/357/commits/d183c5c5aefacfe0878d17996ae8601646e14b26 I will undo it, if possible

ue71603 commented 1 year ago

did it now on: https://github.com/VDVde/OJP/pull/381 hope it works