search

VDVde / OJP

Open API for distributed journey planning. CEN/TS 17118:2017.
https://www.vdv.de/open-journey-planner.aspx
22 stars 12 forks source link

Relocate BikeTransport #368

Closed trurlurl closed 1 year ago

trurlurl commented 1 year ago

Problem: BikeTransport vanished from MultiPointTripParamStructure and from BookingUserStructure. To blame is a change done in PR #353. I propose simply reverting that change - i.e., putting BikeTransport back to TripMobilityFilterGroup. Other solutions would be possible.

ue71603 commented 1 year ago

@trurlurl I think it is moved to BaseTripPolicyGroup. So I think it is still there. Or do you not find it?

trurlurl commented 1 year ago

@trurlurl I think it is moved to BaseTripPolicyGroup. So I think it is still there. Or do you not find it?

@ue71603 No, I don't find it in BaseTripPolicyGroup. Even if it were there - it would't appear in BookingUserStructure in that case, so that wouldn't be what is wanted, I guess?

BaseTripMobilityFilterGroup would work in that respect, as does the current proposal.

skinkie commented 1 year ago

Please resolve conflicts :)

ue71603 commented 1 year ago

@skinkie : Did we make the thing redudant?