search

VDVde / OJP

Open API for distributed journey planning. CEN/TS 17118:2017.
https://www.vdv.de/open-journey-planner.aspx
22 stars 12 forks source link

TripChangeRequest - parameters missing #383

Closed trurlurl closed 1 year ago

trurlurl commented 1 year ago

I still think that the TripChangeRequest - #381 - needs to know many of the inital parameters that were used to find the trip to be changed.

Currently, there is only TripContentFilterGroup and OperatorFilter.

The easiest would probably be to have the complete TripParamStructure, then you can decide which parameters to use and which not. I think the parameter element should be compulsory and the examples have to be adapted.

I might do the PR, but only if @herlitze agrees on the problem, solution, and procedure.

herlitze commented 1 year ago

@trurlurl I agree with adding the TripParamStructure, but I think it should be optional as it is optional in the TripRequest as well. I would appreciate it if you could take over the PR, but I can of course correct my carelessness myself.

trurlurl commented 1 year ago

Solved by the referring PR.