VDVde / OJP

Open API for distributed journey planning. CEN/TS 17118:2017.
https://www.vdv.de/open-journey-planner.aspx
22 stars 12 forks source link

Wrap all maxOccurs into an element #388

Open ue71603 opened 11 months ago

ue71603 commented 11 months ago

In NeTEx 0:n or 1:n are usually wrapped in an element. This is not done in SIRI and OJP.

Perhaps they should be. This would make a conversion to JSON a lot easier:

For possible JSON implementation having groups around everything that can exist n times would be great. Currently ServiceSection is just 1:n

We have about 40-50 instances in OJP. Should we do it? We have some, where we did it.

herlitze commented 11 months ago

I am open to it, but a JSON implementation would be defined by a JSON Schema and not a XSD. So we should think about creating a JSON Schema.

skinkie commented 11 months ago

I am open to it, but a JSON implementation would be defined by a JSON Schema and not a XSD. So we should think about creating a JSON Schema.

That is already done by undersigned for OSDM. An automatic process is still something that may be interesting.

ue71603 commented 11 months ago

The wrapping was not done in SIRI either. So, we would break it there. For OJP about 150 cases need to be addressed: C:\Users\ue71603\MG_Daten\github\OJP4\OJP\OJP_Availability.xsd (Ln 26, Char 64) (Ln 231, Char 77) (Ln 255, Char 80) (Ln 260, Char 93) C:\Users\ue71603\MG_Daten\github\OJP4\OJP\OJP_Common.xsd (Ln 79, Char 76) (Ln 100, Char 74) (Ln 125, Char 68) (Ln 138, Char 82) (Ln 161, Char 63) (Ln 244, Char 80) (Ln 249, Char 76) (Ln 402, Char 75) C:\Users\ue71603\MG_Daten\github\OJP4\OJP\OJP_Fare.xsd (Ln 72, Char 51) (Ln 106, Char 49) (Ln 123, Char 75) (Ln 146, Char 77) (Ln 167, Char 70) (Ln 172, Char 80) (Ln 185, Char 81) (Ln 198, Char 77) (Ln 203, Char 75) (Ln 244, Char 89) (Ln 249, Char 77) (Ln 259, Char 75) C:\Users\ue71603\MG_Daten\github\OJP4\OJP\OJP_FareSupport.xsd (Ln 16, Char 83) (Ln 96, Char 61) (Ln 109, Char 36) (Ln 222, Char 83) (Ln 329, Char 71) (Ln 379, Char 85) (Ln 404, Char 67) (Ln 480, Char 78) (Ln 515, Char 77) (Ln 624, Char 85) (Ln 629, Char 82) (Ln 644, Char 94) (Ln 661, Char 69) (Ln 666, Char 69) (Ln 671, Char 102) (Ln 703, Char 77) (Ln 714, Char 77) (Ln 719, Char 75) (Ln 757, Char 78) (Ln 770, Char 90) (Ln 775, Char 91) (Ln 793, Char 77) C:\Users\ue71603\MG_Daten\github\OJP4\OJP\OJP_JourneySupport.xsd (Ln 141, Char 73) (Ln 146, Char 80) (Ln 362, Char 68) (Ln 373, Char 70) (Ln 436, Char 69) (Ln 441, Char 70) (Ln 588, Char 107) (Ln 761, Char 111) ...ement name="IncludeAccessibilityDetails" type="AccessibilityDetailsProfileEnumeration" minOccurs="0" maxOccurs="unbounded"> (Ln 822, Char 65) C:\Users\ue71603\MG_Daten\github\OJP4\OJP\OJP_Lines.xsd (Ln 19, Char 75) (Ln 27, Char 77) (Ln 47, Char 79) (Ln 52, Char 71) (Ln 57, Char 63) C:\Users\ue71603\MG_Daten\github\OJP4\OJP\OJP_Locations.xsd (Ln 48, Char 77) (Ln 75, Char 87) (Ln 143, Char 81) (Ln 152, Char 77) (Ln 178, Char 63) (Ln 197, Char 65) (Ln 226, Char 70) (Ln 246, Char 93) (Ln 332, Char 70) (Ln 352, Char 93) (Ln 362, Char 88) (Ln 371, Char 65) (Ln 400, Char 95) (Ln 409, Char 77) (Ln 434, Char 63) C:\Users\ue71603\MG_Daten\github\OJP4\OJP\OJP_ModesSupport.xsd (Ln 164, Char 91) (Ln 169, Char 57) (Ln 182, Char 80) C:\Users\ue71603\MG_Daten\github\OJP4\OJP\OJP_PlaceSupport.xsd (Ln 49, Char 77) (Ln 109, Char 77) (Ln 180, Char 77) (Ln 244, Char 101) (Ln 249, Char 77) (Ln 267, Char 53) (Ln 272, Char 70) (Ln 284, Char 76) (Ln 328, Char 101) (Ln 405, Char 77) (Ln 479, Char 80) (Ln 513, Char 80) C:\Users\ue71603\MG_Daten\github\OJP4\OJP\OJP_RequestSupport.xsd (Ln 77, Char 77) (Ln 105, Char 51) (Ln 113, Char 70) C:\Users\ue71603\MG_Daten\github\OJP4\OJP\OJP_SituationSupport.xsd (Ln 13, Char 89) (Ln 18, Char 93) (Ln 43, Char 39) C:\Users\ue71603\MG_Daten\github\OJP4\OJP\OJP_StopEvents.xsd (Ln 176, Char 85) (Ln 199, Char 77) (Ln 216, Char 81) (Ln 226, Char 79) C:\Users\ue71603\MG_Daten\github\OJP4\OJP\OJP_TripInfo.xsd (Ln 139, Char 77) (Ln 144, Char 77) (Ln 154, Char 75) C:\Users\ue71603\MG_Daten\github\OJP4\OJP\OJP_Trips.xsd (Ln 16, Char 59) (Ln 21, Char 64) (Ln 26, Char 65) (Ln 32, Char 83) (Ln 38, Char 67) (Ln 43, Char 75) (Ln 115, Char 86) (Ln 383, Char 75) (Ln 406, Char 77) (Ln 423, Char 77) (Ln 481, Char 79) (Ln 535, Char 47) (Ln 542, Char 79) (Ln 616, Char 86) (Ln 631, Char 79) (Ln 642, Char 85) (Ln 691, Char 80) (Ln 701, Char 79) (Ln 760, Char 79) (Ln 861, Char 79) (Ln 898, Char 67) (Ln 1275, Char 102) (Ln 1280, Char 53) (Ln 1327, Char 59) (Ln 1332, Char 64) (Ln 1337, Char 65) (Ln 1342, Char 67) (Ln 1347, Char 75) (Ln 1442, Char 95) (Ln 1465, Char 77) (Ln 1483, Char 77) (Ln 1574, Char 59) (Ln 1611, Char 74) (Ln 1616, Char 75) C:\Users\ue71603\MG_Daten\github\OJP4\OJP\OJP_Utility.xsd (Ln 62, Char 71)

ue71603 commented 10 months ago

@Aurige : What do you think?

ue71603 commented 9 months ago

We will do this, when Siri has done before.