VDVde / OJP

Open API for distributed journey planning. CEN/TS 17118:2017.
https://www.vdv.de/open-journey-planner.aspx
22 stars 12 forks source link

ContinuousMode #392

Closed ue71603 closed 1 year ago

ue71603 commented 1 year ago

When I have a look at what we discussed, then ContinuosMode demandResponsive should no longer exist. We said that demandResponsive is always a TimedLeg

image

<xs:simpleType name="ContinuousModesEnumeration">
    <xs:annotation>
        <xs:documentation>Types of cmodes that  run at any time without a timetable.</xs:documentation>
    </xs:annotation>
    <xs:restriction base="xs:string">
        <xs:enumeration value="walk"/>
        <xs:enumeration value="demandResponsive"/>
        <xs:enumeration value="replacementService"/>
    </xs:restriction>

ContinuousMode is used in TransferLeg and ContinuousLeg.

Probably ContinuousMode should more contains

Also why does ConinuousServiceStructure need a DatedJourneyGroup? For taxi and vehicle pooling in the form of a SINGLE JOURNEY?

If so, we probably need input from the MODE OF OPERATION discussion anyhow. E.g. vehicle pooling and taxi should be part of ContinuousMode:

        <xs:enumeration value="others-drive-car"/>
        <xs:enumeration value="ride-pool-car"/>
        <xs:enumeration value="car-sharing"/>
        <xs:enumeration value="cycle-sharing"/>
        <xs:enumeration value="scooter-sharing"/>

Depending on what it means also:

From IndividualModesEnumeration some should move over to ContinuousMode

We also have PrivateModesEnumeration:

Which we use from the driver's perspective. But why is it different from ride-pool-car in Individual.

Came up during updating https://github.com/VDVde/OJP/pull/387

ue71603 commented 1 year ago

@skinkie @Aurige @herlitze @normanoffel When I have a look at https://github.com/VDVde/OJP/pull/379/files (which we wanted to do in 2.1 or so. I guess, we should do it to clean this part of the stuff up. If you can live with it, I will integrate this issue into the PR and make it ready.

herlitze commented 1 year ago