search

VDVde / OJP

Open API for distributed journey planning. CEN/TS 17118:2017.
https://www.vdv.de/open-journey-planner.aspx
22 stars 12 forks source link

Moving HikingProfile and CyclingProfile out of TripContentFilter #427

Closed trurlurl closed 9 months ago

trurlurl commented 9 months ago

The proposal is to move HikingProfile and CyclingProfile out of TripContentFilterGroup since they affect the search behavior and not the information to be returned about the trips found (filtering the information would be my interpretation of what TripContentFilter should do).

trurlurl commented 9 months ago

The proposed PR removes both Profiles from TripRefineRequest and TripChangeRequest. Should I add them there as well?

TripChangeRequestStructure - TripChangeParam - TripParams = TripParamStructure - TripMobilityFilter contains the profiles.

TripRefineRequest does not. I have a more fundamental question: We only have TripResult of the trip to be refined, this does not seem to include the initial TripParams - how is that sufficient to re-retrieve the trip?

trurlurl commented 9 months ago

The proposed PR removes both Profiles from TripRefineRequest and TripChangeRequest. Should I add them there as well?

TripChangeRequestStructure - TripChangeParam - TripParams = TripParamStructure - TripMobilityFilter contains the profiles.

TripRefineRequest does not. I have a more fundamental question: We only have TripResult of the trip to be refined, this does not seem to include the initial TripParams - how is that sufficient to re-retrieve the trip?

Proposal if it is not sufficient: add new OriginalTripParams to TripRefineParamStructure.

ue71603 commented 9 months ago

@herlitze pls check for the filtergroup I added to trip refinement. I hope this is ok for you as well.

ue71603 commented 9 months ago

@skinkie if ok, then pls approve and merge.