VDrift / vdrift

VDrift source code
http://vdrift.net/
GNU General Public License v3.0
353 stars 96 forks source link

snap compilation with locale #173

Open fossfreedom opened 4 years ago

fossfreedom commented 4 years ago

Hi - I thought I would try to experiment creating a snap for vdrift.

I'm having a compilation issue though - any thoughts what this bit of the trace is complaining about?

Install file: "data/tracks/zandvoort/surfaces.txt" as "/root/parts/my-part/install/share/games/vdrift/data/tracks/zandvoort/surfaces.txt"
Install file: "data/tracks/zandvoort/track.txt" as "/root/parts/my-part/install/share/games/vdrift/data/tracks/zandvoort/track.txt"
Install file: "data/tracks/zandvoort/trackshot.png" as "/root/parts/my-part/install/share/games/vdrift/data/tracks/zandvoort/trackshot.png"
mo_builder(["data/locale/de/LC_MESSAGES/vdrift.mo"], ["data/locale/de.po"])
scons: *** [data/locale/de/LC_MESSAGES/vdrift.mo] Error 127
scons: building terminated because of errors.
Failed to run 'scons install release=0 minimal=1 extbullet=1 prefix=/root/parts/my-part/install arch=a64' for 'my-part': Exited with code 2.
Verify that the part is using the correct parameters and try again.
snapcraft-vdrift # ls -l parts/my-part/build/data/locale/de
de/    de.po  
snapcraft-vdrift # ls -l parts/my-part/build/data/locale/de.po
-rw-r--r-- 1 root root 60535 Apr 23 08:22 parts/my-part/build/data/locale/de.po
snapcraft-vdrift # 
leillo1975 commented 4 years ago

I'm here not to help you (sorry, I'm a simple user), but to thank you for trying to create this Snap. I think it's a very good way to make the installation easier for many people who have problems with it on Linux, and in the meantime to let people know about this great project and help its development.

I would ask the Vdrift devs to please give you a hand with this, as I think it is very important that there are Vdrift Snap packages, as well as AppImage and Flatpak.

Please, Keep on working, and of course, THANKS!

leillo1975 commented 4 years ago

No news about this? I think that a lot of people could play this game on Linux without compile the code. This is a big wall for a lot of new users to play this great game. Not only Snap is a good option, Flatpak or AppImage are good packages for distribute the software in a simple way among many Linux distributions. Please devs, give a hand on it.

logzero commented 4 years ago

From my pov the issue with snap and co is about being GPL compatible. It means identifying the GPL subset of VDrift data and only using it for snap and other distribs.

Frankly I've been thinking about using the car/track downloader to download all VDrift data and only distributing the executable.

leillo1975 commented 4 years ago

There are a lot of apps that don't use Open Source licenses that are packed under snap and the other package systems, even propietary software, but as you say, make a standalone package with only the necesary files to start the game and then use it to download the cars and tracks is a perfect solution. This way it would be a package that would not be so big.

Apteryks commented 3 weeks ago

About the art data licensing question, for distribution purposes, the GNU Free Software Distribution Guidelines has this to say about it:

Non-functional Data

Data that isn't functional, that doesn't do a practical job, is more of an adornment to the system's software than a part of it. Thus, we don't insist on the free license criteria for non-functional data. It can be included in a free system distribution as long as its license gives you permission to copy and redistribute, both for commercial and non-commercial purposes. For example, some game engines released under the GNU GPL have accompanying game information—a fictional world map, game graphics, and so on—released under such a verbatim-distribution license. This kind of data can be part of a free system distribution, even though its license does not qualify as free, because it is non-functional.

For the full text: https://www.gnu.org/distros/free-system-distribution-guidelines.html

While it'd be much nicer that the whole data be under the GPL or some creative commons license, if it's at least freely distributable for both commercial or non-commercial purposes, then per the GNU FSDG it's OK to be included in a free software distribution.