search

VE3NEA / enigma-cuda

11 stars 5 forks source link

Zeroing xgrams if file not supplied. #3

Closed matszpk closed 7 years ago

matszpk commented 7 years ago

Zeroing xgrams if file not supplied. Maybe other fix needed to solve problem with unitialized data. Maybe this fix is obsolete (i am not expert of CUDA). I found in my prepared version random data in d_bigrams (bigrams file was not supplied) while testing and I resolve that problem in similar way.

VE3NEA commented 7 years ago

Thank you for the contribution! However, the program should not be allowed to continue if required n-gram data are missing. It should terminate immediately, with a meaningful error message. Therefore, there is no need in zeroing the data. The n-gram data that is not used in the current mode is not accessed at all, so no need to zero it either.

matszpk commented 7 years ago

Actually, this is not required. Errors caused by other bug in my code.