VEINHORN / ScrollGalleryView

:bridge_at_night: Android image gallery with bottom scroll view
MIT License
531 stars 157 forks source link

Add getCurrentItem method to ScrollGalleryView #45

Closed voghDev closed 7 years ago

voghDev commented 7 years ago

This is the simplest version of the change. I've just added getCurrentItem() that exposes the same method from ViewPager.

I just noticed that you've added a getViewPager() method where you can get the whole ViewPager object. Maybe this could lead to bad usages from library users, such as changing the adapter and breaking up the whole thing.

Anyway, if you want to include this method in the next version, I think it could be useful :) I wait for the next release to have some issues like #27 or #32 fixed.

I've also had a look at #43. I think it is related to this code:

public ScrollGalleryView setCurrentItem(int i) {
    viewPager.setCurrentItem(i, false);
    return this;
}

I've just discovered that setCurrentItem can be called before initializing the ViewPager, so it causes NullPointerException. A workaround could be calling .setCurrentItem after .setFragmentManager. I'll update my comment in #43.

VEINHORN commented 7 years ago

@voghDev thank you. 👌

voghDev commented 7 years ago

You're welcome :) are you planning to release a new version of the library with the most recent changes?

VEINHORN commented 6 years ago

1.0.7 is available for now. 1.0.8 is coming.