writelaserinDB missing in v486b

[qi-feng]

writelaserinDB is used for the nextday and it's missing in v486b. The old writelaserinDB source code won't compile, errors copied below:

g++ -O3 -g -Wall -fPIC -fno-strict-aliasing -D_FILE_OFFSET_BITS=64 -D_LARGE_FILE_SOURCE -D_LARGEFILE64_SOURCE -std=c++14 -I. -I./inc/ -DRUNWITHDB -DROOT6 -DGSL2 -DRUNWITHDCACHE -pthread -m64 -I/usr/include/root -I/usr/include/root/TMVA -I/usr/local//include/VBF/ -I/usr/include -DGSL2 -I/usr//include/cfitsio -c -o obj/writelaserinDB.o src/writelaserinDB.cpp src/writelaserinDB.cpp: In function ‘void write_calib_DB(TString)’: src/writelaserinDB.cpp:495:57: error: no matching function for call to ‘VDB_CalibrationInfo::write_inVOFFLINE_DB_from_file(std::__cxx11::string&)’ db_calib_info->write_inVOFFLINE_DB_from_file(fpass_word); ^ In file included from src/writelaserinDB.cpp:34: ./inc/VDB_CalibrationInfo.h:72:8: note: candidate: ‘void VDB_CalibrationInfo::write_inVOFFLINE_DB_from_file()’ void write_inVOFFLINE_DB_from_file(); ^~~~~~~~~ ./inc/VDB_CalibrationInfo.h:72:8: note: candidate expects 0 arguments, 1 provided make: *** [Makefile:1185: obj/writelaserinDB.o] Error 1

[GernotMaier]

I think there is some confusion between writelaserinDB and updateDBlaserRUN.

writelaserinDB does not exist anymore and it is not clear to me why, are you sure this one is used?

Going back in history, both codes are 75% identical and I don't understand exactly which one is used for what. Do you use updateDBlaserRUN for anything?

[GernotMaier]

I have added now again the writelaserinDB file, reviewed and tested it locally. Will merge the pull request in a minute.

[qi-feng]

Thanks for making this update. It's used in nextday for flasher runs. We can probably figure out how to change the nextday script to use updateDBlaserRUN instead; but since you added it back, we can keep nextday as is.