Eventdisplay v490 is a major update with several planned additions.
Important for @GernotMaier : run astyle --options=./.astylerc after merging to improve code style (see also issue #175)
Optimised next-neighbour cleaning
(back ported from v5)
Should improve the low-energy response.
Replacement of slalib routines by sofa
see PR #180
Eventdisplay has been using a copy of the slalib code since the very beginning (VASlalib). All astronometry routines are replaced by the sofa package (same authors as slalib; but permissive licence) for the following reasons:
slalib (as used in Eventdisplay) is not maintained since many years and the status of the routines is unclear (e.g. means that timing routines do not include leap seconds introduced recently)
slalib's licence unclear and very likely the current usage Eventdisplay is not allowed
sofa is a well maintained IAU package
PR 180 lists some tests listing differences between using the two different astronometry packages: generally consistent results with max differences in reconstructions observations of <2 arcseconds.
Note that this involves the installation of the sofa package before compiling eventdisplay. Use the script install_sofa.sh to download and install the package.
Addition of mergeVBF binaries
mergeVBF is used for the simulation production to merge several (possibly 1000s) of simulation vbf files into one file.
Improved MC/Data comparison plots
Improvements to MC/Data comparison includes:
weighting of events according to the azimuth of the data runs
energy-dependent theta2 comparision
Code cleanup
Eventdisplay-code base includes a lot of obsolete code which makes maintenance more difficult than necessary. Try and remove anything which will not be used in future: CTA-related code (uses v5), frogs and 3D model (will realistically never by used and would require a re-implementation); other smaller bits.
Eventdisplay v490 is a major update with several planned additions.
Important for @GernotMaier : run
astyle --options=./.astylercafter merging to improve code style (see also issue #175)Optimised next-neighbour cleaning
(back ported from v5)
Should improve the low-energy response.
Replacement of slalib routines by sofa
see PR #180
Eventdisplay has been using a copy of the slalib code since the very beginning (VASlalib). All astronometry routines are replaced by the sofa package (same authors as slalib; but permissive licence) for the following reasons:
PR 180 lists some tests listing differences between using the two different astronometry packages: generally consistent results with max differences in reconstructions observations of <2 arcseconds.
Note that this involves the installation of the
sofapackage before compiling eventdisplay. Use the scriptinstall_sofa.shto download and install the package.Addition of mergeVBF binaries
mergeVBFis used for the simulation production to merge several (possibly 1000s) of simulation vbf files into one file.Improved MC/Data comparison plots
Improvements to MC/Data comparison includes:
Code cleanup
Eventdisplay-code base includes a lot of obsolete code which makes maintenance more difficult than necessary. Try and remove anything which will not be used in future: CTA-related code (uses v5), frogs and 3D model (will realistically never by used and would require a re-implementation); other smaller bits.
Associated branches: