search

VERITAS-Observatory / EventDisplay_v4

A reconstruction and analysis pipeline for VERITAS.
BSD 3-Clause "New" or "Revised" License
4 stars 1 forks source link

Deal with short runs with low number of events required for IPR Grphs #209

Closed GernotMaier closed 2 years ago

GernotMaier commented 2 years ago

Typical 20-30 mins runs provide 1200-1800 pedestal events per telescopes - enough to calculate the IPR graphs per telescopes for the threshold determination in the optimisated NN cleaning. This allows to take throughput and gain differences of the telescopes into account.

This is not the case for very short runs. In this case, pedestal histograms from all telescopes are combined to produce an average IPR graph. This PR is the implemented of calculating the average graphs in case there are less than fPedPerTelescopeTypeMinCnt available.

GernotMaier commented 2 years ago

@m-kherlakian this looks good and I would be ok with merging it. Is it complete or do you want to add anything? I guess the plots you've shown me yesterday are from testing the code and it works? Also no impact on the 'normal' analysis with telescope-depending IPR graphs?

mariakherlakian commented 2 years ago

@GernotMaier I am doing a test with a normal 20 minutes run. I also noticed that the cloned histograms for the remaining (>2 ) telescopes are empty in the IPR.root file, so I am also checking why.

mariakherlakian commented 2 years ago

@m-kherlakian this looks good and I would be ok with merging it. Is it complete or do you want to add anything? I guess the plots you've shown me yesterday are from testing the code and it works? Also no impact on the 'normal' analysis with telescope-depending IPR graphs?

@GernotMaier the version is ready to be merged. The IPR graphs for short runs are consistent for every telescope and there is no change for longer runs.

short_run-66786

avgtel

GernotMaier commented 2 years ago

Very nice, this looks really good now!

Ready to merge from my point of view.

Note that I've submitted some minor changes in code formatting (no code change). This is to make sure that the code has a uniform patter, easiest to achieve when doing make formatSourceCode when you are ready with the development.